Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the string handling architecture by transitioning AString and AStringView to byte-based iterators and introducing AUtf8View for Unicode-aware operations. Feedback highlights several critical issues: the removal of append(AChar) will cause compilation failures in dependent methods, the AUtf8View::endsWith method is missing its implementation, and simdutf::validate_utf8 is called with incompatible arguments. Additionally, the shift to byte-based iterators breaks Unicode logic in existing AString methods, and AUtf8View's at() method lacks sufficient bounds checking. The reviewer also recommended addressing the counter-intuitive O(N) complexity of AUtf8View indexing and removing commented-out dead code.
|
|
||
|
|
||
| /** | ||
| * @brief Represents a UTF-8 string view. |
| class API_AUI_CORE AUtf8View; | ||
|
|
||
| /** | ||
| * @brief Represents a UTF-8 string. |
2 participants
No description provided.