Skip to content

fix: warn agents about yarn verify Deploy.s.sol naming requirement#114

Open
austintgriffith wants to merge 1 commit intomasterfrom
fix/yarn-verify-warning
Open

fix: warn agents about yarn verify Deploy.s.sol naming requirement#114
austintgriffith wants to merge 1 commit intomasterfrom
fix/yarn-verify-warning

Conversation

@austintgriffith
Copy link
Copy Markdown
Owner

Problem

yarn verify fails with No such file or directory if the deploy script isn't named exactly Deploy.s.sol. VerifyAll.s.sol hardcodes the broadcast artifact path to broadcast/Deploy.s.sol/<chainId>/run-latest.json — any custom script name produces this error. Discovered in the wild with DeployMetaMultiSigWallet.s.sol.

Two previous PRs (#112, #113) tried to fix this but had issues:

Fix

Adds a clean ⚠️ pre-condition callout before yarn verify that:

  • Uses the accurate error message (No such file or directory, not "silent failure")
  • Steers agents toward the Foundry fallback instead of renaming files
  • Has proper blank-line separation from the code fence

What this does NOT fix

The root cause is in VerifyAll.s.sol in scaffold-eth — it should derive the broadcast path from the actual script name rather than hardcoding Deploy.s.sol. That's a scaffold-eth PR, not an ethskills change.

Closes #112, closes #113

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
site Ready Ready Preview Mar 8, 2026 2:38am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant