fix: warn agents about yarn verify Deploy.s.sol naming requirement#114
Open
austintgriffith wants to merge 1 commit intomasterfrom
Open
fix: warn agents about yarn verify Deploy.s.sol naming requirement#114austintgriffith wants to merge 1 commit intomasterfrom
austintgriffith wants to merge 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
yarn verifyfails withNo such file or directoryif the deploy script isn't named exactlyDeploy.s.sol.VerifyAll.s.solhardcodes the broadcast artifact path tobroadcast/Deploy.s.sol/<chainId>/run-latest.json— any custom script name produces this error. Discovered in the wild withDeployMetaMultiSigWallet.s.sol.Two previous PRs (#112, #113) tried to fix this but had issues:
No such file or directory); bundled a stale gas timestamp changeFix
Adds a clean⚠️ pre-condition callout before
yarn verifythat:No such file or directory, not "silent failure")What this does NOT fix
The root cause is in
VerifyAll.s.solin scaffold-eth — it should derive the broadcast path from the actual script name rather than hardcodingDeploy.s.sol. That's a scaffold-eth PR, not an ethskills change.Closes #112, closes #113