-
Notifications
You must be signed in to change notification settings - Fork 16
fix(auth0-server-js): correctly compare scopes before calling auth0 #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import { expect, test } from 'vitest'; | ||
| import { compareScopes } from './utils.js'; | ||
|
|
||
| test('should match scopes when more scopes are available', () => { | ||
| const scopes = 'a b'; | ||
| const requiredScopes = 'a'; | ||
|
|
||
| expect(compareScopes(scopes, requiredScopes)).toBe(true); | ||
| }); | ||
|
|
||
| test('should match exact scopes', () => { | ||
| const scopes = 'a b'; | ||
| const requiredScopes = 'a b'; | ||
|
|
||
| expect(compareScopes(scopes, requiredScopes)).toBe(true); | ||
| }); | ||
|
|
||
| test('should match exact scopes in reverse order', () => { | ||
| const scopes = 'a b'; | ||
| const requiredScopes = 'b a'; | ||
|
|
||
| expect(compareScopes(scopes, requiredScopes)).toBe(true); | ||
| }); | ||
|
|
||
| test('should match when both empty', () => { | ||
| const scopes = ''; | ||
| const requiredScopes = ''; | ||
|
|
||
| expect(compareScopes(scopes, requiredScopes)).toBe(true); | ||
| }); | ||
|
|
||
| test('should not match when scopes empty', () => { | ||
| const scopes = ''; | ||
| const requiredScopes = 'a b c d'; | ||
|
|
||
| expect(compareScopes(scopes, requiredScopes)).toBe(false); | ||
| }); | ||
|
|
||
| test('should not match when requiredScopes empty', () => { | ||
| const scopes = 'a b'; | ||
| const requiredScopes = ''; | ||
|
|
||
| expect(compareScopes(scopes, requiredScopes)).toBe(false); | ||
| }); | ||
|
|
||
| test('should not match when no scope included', () => { | ||
| const scopes = 'a b'; | ||
| const requiredScopes = 'c d'; | ||
|
|
||
| expect(compareScopes(scopes, requiredScopes)).toBe(false); | ||
| }); | ||
|
|
||
| test('should not match when some scopes not included', () => { | ||
| const scopes = 'a b'; | ||
| const requiredScopes = 'a b c d'; | ||
|
|
||
| expect(compareScopes(scopes, requiredScopes)).toBe(false); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /** | ||
| * Compares two sets of scopes to determine if all required scopes are present in the provided scopes. | ||
| * @param scopes Scopes to compare | ||
| * @param requiredScopes Scopes required to be present in the scopes | ||
| * @returns True if all required scopes are present in the scopes, false otherwise | ||
| */ | ||
| export const compareScopes = (scopes: string | undefined, requiredScopes: string | undefined) => { | ||
| if (!scopes && !requiredScopes) { | ||
|
frederikprijck marked this conversation as resolved.
Outdated
|
||
| return true; | ||
| } | ||
|
|
||
| if (!scopes || !requiredScopes) { | ||
| return false; | ||
| } | ||
|
|
||
| const scopesArray = scopes.split(' '); | ||
|
frederikprijck marked this conversation as resolved.
Outdated
|
||
| const requiredScopesArray = requiredScopes.split(' '); | ||
|
|
||
| return requiredScopesArray.every((scope) => scopesArray.includes(scope)); | ||
|
frederikprijck marked this conversation as resolved.
Outdated
|
||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.