-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add github registry support #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4d764c7
feat: add github registry support (hybrid option 2)
harishsundar-okta af01197
chore: resolve merge conflicts with main in registry.json
harishsundar-okta 7c11f50
chore: regenerate registry.json with react prefix and framework metadata
harishsundar-okta 4959265
ci: add registry.json drift check to fail if catalog is stale
harishsundar-okta 6cf4c98
fix: pin shadcn version in ci and fix deprecation headers
harishsundar-okta 05adf97
Merge remote-tracking branch 'origin/main' into feat/github-registry-…
harishsundar-okta fa51b99
chore: regenerate registry.json after merge with main
harishsundar-okta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Keep GitHub Registry version tags immutable.
Deleting and recreating
v${VERSION}can make the same installation ref resolve to different source. Fail if the release tag already exists instead of moving it.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional design — the delete-and-recreate behavior is needed because our publish workflow can be re-run on failure (e.g. partial npm publish). If the tag were immutable, a retry after a transient failure would require manual tag cleanup before the workflow could succeed. Since the tag always points to the same commit within a single workflow run, consumers installing by tag still get deterministic resolution for any given release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description image shows a dark terminal running:
npx shadcn add auth0/auth0-ui-components/react/my-account/user-mfa-management#feat/github-registry-hybridIt installs
shadcn@4.13.0, reports successful registry and dependency checks, confirms overwritingbutton.tsxandutils.ts, and lists “Created 60 files”, includingsrc/components/auth/my-account/user-mfa-management.tsxand multiple MFA-related components.@harishsundar-okta, thanks for clarifying the retry requirement. I agree that avoiding manual cleanup after a failed release is valuable.However, a rerun is not necessarily the same workflow run or the same commit:
workflow_dispatchmay be invoked from a different ref, while retaining the same package version. The current delete-and-recreate flow would then movev${VERSION}, so consumers using that tag could receive different registry content over time.The finding therefore still applies as an intentional tradeoff rather than an accidental behavior. If mutable tags are the accepted release policy, no change is needed here; documenting that policy near this block would help make the consumer-facing contract explicit.
✏️ Learnings added