-
Notifications
You must be signed in to change notification settings - Fork 7
feat(permissions): add permission manifest constant, types utilities, my-org tarball #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grandmaester
wants to merge
5
commits into
feat/my-org-ea-branch
Choose a base branch
from
feat/permission-gating-infrastructure
base: feat/my-org-ea-branch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ab84280
feat: adding latest my-org tarball for permissions apis
grandmaester d8094de
feat: permission manifest constant and utils with types and tests
grandmaester 49da105
feat: review comments incorporated
grandmaester dff714e
feat: added missing permissions to manifest, fixed util types
grandmaester 47935eb
Merge remote-tracking branch 'origin' into feat/permission-gating-inf…
grandmaester File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
114 changes: 114 additions & 0 deletions
114
packages/core/src/services/my-organization/permissions/__tests__/permission-utils.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| import { | ||
| getUserTier, | ||
| hasAllPermissions, | ||
| hasAnyPermission, | ||
| hasPermission, | ||
| } from '../permission-utils'; | ||
|
|
||
| describe('permission-utils', () => { | ||
| describe('hasPermission', () => { | ||
| it('returns true when the permission is present', () => { | ||
| expect( | ||
| hasPermission( | ||
| ['read:my_org:members', 'delete:my_org:memberships'], | ||
| 'delete:my_org:memberships', | ||
| ), | ||
| ).toBe(true); | ||
| }); | ||
|
|
||
| it('returns false when the permission is absent', () => { | ||
| expect(hasPermission(['read:my_org:members'], 'delete:my_org:memberships')).toBe(false); | ||
| }); | ||
|
|
||
| it('returns false for an empty permission list', () => { | ||
| expect(hasPermission([], 'read:my_org:members')).toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| describe('hasAnyPermission', () => { | ||
| it('returns true when at least one permission is present', () => { | ||
| expect( | ||
| hasAnyPermission( | ||
| ['read:my_org:members'], | ||
| ['delete:my_org:memberships', 'read:my_org:members'], | ||
| ), | ||
| ).toBe(true); | ||
| }); | ||
|
|
||
| it('returns false when none of the permissions are present', () => { | ||
| expect( | ||
| hasAnyPermission( | ||
| ['read:my_org:members'], | ||
| ['delete:my_org:memberships', 'create:my_org:member_roles'], | ||
| ), | ||
| ).toBe(false); | ||
| }); | ||
|
|
||
| it('returns true when the required list is empty (vacuously satisfied)', () => { | ||
| expect(hasAnyPermission([], [])).toBe(true); | ||
| }); | ||
| }); | ||
|
|
||
| describe('hasAllPermissions', () => { | ||
| it('returns true only when every required permission is present', () => { | ||
| expect( | ||
| hasAllPermissions( | ||
| ['read:my_org:members', 'delete:my_org:memberships'], | ||
| ['read:my_org:members', 'delete:my_org:memberships'], | ||
| ), | ||
| ).toBe(true); | ||
| }); | ||
|
|
||
| it('returns false when any required permission is missing', () => { | ||
| expect( | ||
| hasAllPermissions( | ||
| ['read:my_org:members'], | ||
| ['read:my_org:members', 'delete:my_org:memberships'], | ||
| ), | ||
| ).toBe(false); | ||
| }); | ||
|
|
||
| it('returns true when the required list is empty (vacuously satisfied)', () => { | ||
| expect(hasAllPermissions([], [])).toBe(true); | ||
| }); | ||
| }); | ||
|
|
||
| describe('getUserTier', () => { | ||
| it('returns "admin" when the user can delete the resource', () => { | ||
| expect(getUserTier(['read:my_org:domains', 'delete:my_org:domains'], 'domains')).toBe( | ||
| 'admin', | ||
| ); | ||
| }); | ||
|
|
||
| it('returns "editor" when the user can create/update but not delete', () => { | ||
| expect(getUserTier(['read:my_org:domains', 'update:my_org:domains'], 'domains')).toBe( | ||
| 'editor', | ||
| ); | ||
| expect(getUserTier(['create:my_org:domains'], 'domains')).toBe('editor'); | ||
| }); | ||
|
|
||
| it('returns "viewer" for read-only access', () => { | ||
| expect(getUserTier(['read:my_org:members'], 'members')).toBe('viewer'); | ||
| }); | ||
|
|
||
| it('returns "viewer" when the user has no permissions for the resource', () => { | ||
| expect(getUserTier(['read:my_org:domains'], 'members')).toBe('viewer'); | ||
| expect(getUserTier([], 'members')).toBe('viewer'); | ||
| }); | ||
|
|
||
| it('matches the resource segment exactly (sub-resources are distinct)', () => { | ||
| expect(getUserTier(['delete:my_org:member_roles'], 'member_roles')).toBe('admin'); | ||
| expect(getUserTier(['create:my_org:member_roles'], 'member_roles')).toBe('editor'); | ||
| expect(getUserTier(['read:my_org:members', 'delete:my_org:member_roles'], 'members')).toBe( | ||
| 'viewer', | ||
| ); | ||
| }); | ||
|
|
||
| it('does not conflate distinct resources that share a prefix', () => { | ||
| expect(getUserTier(['delete:my_org:memberships'], 'members')).toBe('viewer'); | ||
| expect(getUserTier(['delete:my_org:memberships'], 'memberships')).toBe('admin'); | ||
| }); | ||
| }); | ||
| }); |
49 changes: 49 additions & 0 deletions
49
packages/core/src/services/my-organization/permissions/permission-manifest.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /** | ||
| * MyOrganization permission manifest. | ||
| * | ||
| * The full, type-safe set of MyOrganization API permissions | ||
| * @module permission-manifest | ||
| * @internal | ||
| */ | ||
|
|
||
| import type { OauthScope } from './permission-types'; | ||
|
|
||
| export const PERMISSION_MANIFEST: readonly OauthScope[] = [ | ||
| // Members | ||
| 'read:my_org:members', | ||
| 'delete:my_org:memberships', | ||
| // Member Roles | ||
| 'read:my_org:member_roles', | ||
| 'create:my_org:member_roles', | ||
| 'delete:my_org:member_roles', | ||
| // Invitations | ||
| 'read:my_org:member_invitations', | ||
| 'create:my_org:member_invitations', | ||
| 'delete:my_org:member_invitations', | ||
| // Identity Providers | ||
| 'create:my_org:identity_providers', | ||
| 'read:my_org:identity_providers', | ||
| 'update:my_org:identity_providers', | ||
| 'delete:my_org:identity_providers', | ||
| 'update:my_org:identity_providers_detach', | ||
| // IDP Domains, Provisioning, SCIM | ||
| 'create:my_org:identity_providers_domains', | ||
| 'delete:my_org:identity_providers_domains', | ||
| 'read:my_org:identity_providers_provisioning', | ||
| 'create:my_org:identity_providers_provisioning', | ||
| 'update:my_org:identity_providers_provisioning', | ||
| 'delete:my_org:identity_providers_provisioning', | ||
| 'read:my_org:identity_providers_scim_tokens', | ||
| 'create:my_org:identity_providers_scim_tokens', | ||
| 'delete:my_org:identity_providers_scim_tokens', | ||
| // Domains | ||
| 'read:my_org:domains', | ||
| 'create:my_org:domains', | ||
| 'update:my_org:domains', | ||
| 'delete:my_org:domains', | ||
| // Org Details | ||
| 'read:my_org:details', | ||
| 'update:my_org:details', | ||
| // Configuration | ||
| 'read:my_org:configuration', | ||
| ]; |
8 changes: 8 additions & 0 deletions
8
packages/core/src/services/my-organization/permissions/permission-query-keys.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| /** | ||
| * Permission query keys for TanStack Query cache management. | ||
| * @module permission-query-keys | ||
| */ | ||
| export const permissionQueryKeys = { | ||
| all: ['permissions'] as const, | ||
| list: () => [...permissionQueryKeys.all, 'list'] as const, | ||
| }; |
24 changes: 24 additions & 0 deletions
24
packages/core/src/services/my-organization/permissions/permission-types.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /** | ||
| * Permission type definitions. | ||
| * @module permission-types | ||
| * @internal | ||
| */ | ||
| import type { MyOrganization } from '@auth0/myorganization-js'; | ||
|
|
||
| /** Response body of `GET /my-org/user-permissions` — the granted subset of requested permissions. */ | ||
| export type GetUserPermissionsResponseContent = MyOrganization.GetUserPermissionsResponseContent; | ||
|
|
||
| /** Request parameters for `GET /my-org/user-permissions` (comma-separated permission list). */ | ||
| export type GetUserPermissionsRequestParameters = | ||
| MyOrganization.GetUserPermissionsRequestParameters; | ||
|
|
||
| /** Behavior tier a user falls into for a given resource, derived from their permissions. */ | ||
| export type PermissionTier = 'admin' | 'editor' | 'viewer'; | ||
|
|
||
| /** A MyOrganization permission scope string (e.g. `delete:my_org:members`), sourced from the SDK. */ | ||
| export type OauthScope = MyOrganization.OauthScope; | ||
|
|
||
| /** The resource segment of a scope (e.g. `members`, `domains`), inferred from {@link OauthScope}. */ | ||
| export type MyOrgResource = OauthScope extends `${string}:${string}:${infer Resource}` | ||
| ? Resource | ||
| : never; |
95 changes: 95 additions & 0 deletions
95
packages/core/src/services/my-organization/permissions/permission-utils.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| /** | ||
| * Permission checks for MyOrganization UI gating. | ||
| * @module permission-utils | ||
| * @internal | ||
| */ | ||
| import type { MyOrgResource, OauthScope, PermissionTier } from './permission-types'; | ||
|
|
||
| /** | ||
| * Whether the user holds `required`. | ||
| * @param userPermissions - Granted permissions. | ||
| * @param required - Permission to check. | ||
| * @returns `true` if present. | ||
| * @internal | ||
| */ | ||
| export function hasPermission(userPermissions: readonly string[], required: OauthScope): boolean { | ||
| return userPermissions.includes(required); | ||
| } | ||
|
|
||
| /** | ||
| * Whether the user holds at least one of `required`. | ||
| * @param userPermissions - Granted permissions. | ||
| * @param required - Candidate permissions. | ||
| * @returns `true` if any match, or `required` is empty. | ||
| * @internal | ||
| */ | ||
| export function hasAnyPermission( | ||
| userPermissions: readonly string[], | ||
| required: readonly OauthScope[], | ||
| ): boolean { | ||
| if (required.length === 0) { | ||
| return true; | ||
| } | ||
| const granted = new Set(userPermissions); | ||
| return required.some((permission) => granted.has(permission)); | ||
| } | ||
|
|
||
| /** | ||
| * Whether the user holds every one of `required`. | ||
| * @param userPermissions - Granted permissions. | ||
| * @param required - Required permissions. | ||
| * @returns `true` if all match, or `required` is empty. | ||
| * @internal | ||
| */ | ||
| export function hasAllPermissions( | ||
| userPermissions: readonly string[], | ||
| required: readonly OauthScope[], | ||
| ): boolean { | ||
| if (required.length === 0) { | ||
| return true; | ||
| } | ||
| const granted = new Set(userPermissions); | ||
| return required.every((permission) => granted.has(permission)); | ||
| } | ||
|
|
||
| /** | ||
| * Verbs held for `resource`, matched exactly against `<verb>:my_org:<resource>`. | ||
| * @param userPermissions - Granted permissions. | ||
| * @param resource - Resource segment (e.g. `members`, `domains`). | ||
| * @returns The distinct verbs for that resource. | ||
| */ | ||
| function getResourceVerbs( | ||
| userPermissions: readonly string[], | ||
| resource: MyOrgResource, | ||
| ): Set<string> { | ||
| const verbs = new Set<string>(); | ||
| for (const permission of userPermissions) { | ||
| const [verb, , resourceSegment] = permission.split(':'); | ||
| if (verb && resourceSegment === resource) { | ||
| verbs.add(verb); | ||
| } | ||
| } | ||
| return verbs; | ||
| } | ||
|
|
||
| /** | ||
| * Behavior tier for `resource`: delete → admin, create/update → editor, else viewer. | ||
| * @param userPermissions - Granted permissions. | ||
| * @param resource - Resource segment to evaluate. | ||
| * @returns The {@link PermissionTier}. | ||
| * @internal | ||
| */ | ||
| export function getUserTier( | ||
| userPermissions: readonly string[], | ||
| resource: MyOrgResource, | ||
| ): PermissionTier { | ||
| const verbs = getResourceVerbs(userPermissions, resource); | ||
|
|
||
| if (verbs.has('delete')) { | ||
| return 'admin'; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. admin can have all create, update and delete scopes right |
||
| } | ||
| if (verbs.has('create') || verbs.has('update')) { | ||
| return 'editor'; | ||
| } | ||
| return 'viewer'; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.