fix: ensure to use pathname instead of '/' when clearing query parameters#544
Open
frederikprijck wants to merge 1 commit intomainfrom
Open
fix: ensure to use pathname instead of '/' when clearing query parameters#544frederikprijck wants to merge 1 commit intomainfrom
frederikprijck wants to merge 1 commit intomainfrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Using
window.history.replaceState({}, '', '/');can, and will cause issues when the application is not served from root.That particular code has the only purpose to remove the query string, not change the URL. Changing the URL happens only when we are using the router.
Whenever a user would handle the code exchange on
https://example.com/foo?code=abc, we would update the URL to behttps://example.com, instead ofhttps://example.com/foo.References
Closes #424
Testing
Checklist