Skip to content

fix: Add missing hashPasswordForCookie to AuthenticationGuard#492

Merged
kishore7snehil merged 1 commit into
mainfrom
fix/hash-password-for-cookie
Apr 8, 2026
Merged

fix: Add missing hashPasswordForCookie to AuthenticationGuard#492
kishore7snehil merged 1 commit into
mainfrom
fix/hash-password-for-cookie

Conversation

@kishore7snehil

@kishore7snehil kishore7snehil commented Apr 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Contributing Changes

Fixed:

Changed:

  • Added hashPasswordForCookie() method to AuthenticationGuard to match Laravel's SessionGuard implementation
  • Added typed parameter and PHPStan-safe type annotation
  • Added 4 test cases covering HMAC consistency, uniqueness across passwords/keys, and null app key fallback

References

@kishore7snehil kishore7snehil requested a review from a team as a code owner April 8, 2026 09:49
tanya732
tanya732 approved these changes Apr 8, 2026
View reviewed changes

@tanya732 tanya732 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kishore7snehil kishore7snehil merged commit 1fee999 into main Apr 8, 2026
28 checks passed
@kishore7snehil kishore7snehil deleted the fix/hash-password-for-cookie branch April 8, 2026 10:15
@kishore7snehil kishore7snehil mentioned this pull request Apr 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tanya732 tanya732 tanya732 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hashPasswordForCookie function is missing in AuthenticationGuard

2 participants

@kishore7snehil @tanya732