cpu: Pin optimized-routines to v26.01 for SVE test

[hholoubk]

Upstream master added SVE2 strchr assembly that fails to build with -march=armv8.2-a+sve on Apollo/Fujitsu-class hosts. Shallow clone the v26.01 release tag so optimized-routines stays SVE-only.

The test is passing with this change:
(1/1) type_specific.io-github-autotest-libvirt.aarch64_cpu_sve.optimized-routines: STARTED
(1/1) type_specific.io-github-autotest-libvirt.aarch64_cpu_sve.optimized-routines: PASS (802.06 s)

Summary by CodeRabbit

• Tests
  • Updated CPU SVE test configuration to pin the test tooling to a specific release branch for more consistent test runs.
  • Improved VM startup reliability in CPU SVE tests by ensuring address caches are refreshed before guest login, reducing intermittent failures.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6ad7f93b-b3f0-4cc6-82c7-5fcd8885739b

📥 Commits

Reviewing files that changed from the base of the PR and between 94682a5 and c3078ec.

📒 Files selected for processing (1)

• libvirt/tests/src/cpu/aarch64_cpu_sve.py

---

Walkthrough

This PR pins the optimized-routines repository clone in the aarch64 CPU SVE test config to branch v26.01, and adds explicit calls to drop the VM address cache using vm.address_cache.drop(vm.get_mac_address(0).lower()) immediately after starting the VM in both prepare_env and run, before waiting for guest login.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: pinning optimized-routines to v26.01 branch for the SVE test, which is clearly demonstrated in the aarch64_cpu_sve.cfg file modification.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

libvirt/tests/cfg/cpu/aarch64_cpu_sve.cfg (1)

54-54: Confirm v26.01 tag pin for optimized-routines clone (avoids missing-ref failures)

In libvirt/tests/cfg/cpu/aarch64_cpu_sve.cfg (line 54), the clone command is now:

optimized_repo_cmd = "git clone --depth=1 -b v26.01 https://github.com/ARM-software/optimized-routines ${target_dir}"

The v26.01 tag exists in https://github.com/ARM-software/optimized-routines, so the pinned ref should resolve correctly at runtime. Keeping the pin improves reproducibility; consider documenting a periodic review for upstream fixes/security updates.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@libvirt/tests/cfg/cpu/aarch64_cpu_sve.cfg` at line 54, Verify that the pinned
tag v26.01 exists upstream and keep the shallow clone pinned in the
optimized_repo_cmd string; add an inline comment near optimized_repo_cmd noting
the intentional tag pin for reproducibility and that the tag should be reviewed
periodically for upstream fixes/security updates, and update your project/test
configuration documentation to include a periodic-review note for this pinned
ref.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@libvirt/tests/cfg/cpu/aarch64_cpu_sve.cfg`:
- Line 54: Verify that the pinned tag v26.01 exists upstream and keep the
shallow clone pinned in the optimized_repo_cmd string; add an inline comment
near optimized_repo_cmd noting the intentional tag pin for reproducibility and
that the tag should be reviewed periodically for upstream fixes/security
updates, and update your project/test configuration documentation to include a
periodic-review note for this pinned ref.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 16ff88f3-e743-43fe-b200-573983ccf47f

📥 Commits

Reviewing files that changed from the base of the PR and between c96ab65 and 94682a5.

📒 Files selected for processing (1)

• libvirt/tests/cfg/cpu/aarch64_cpu_sve.cfg

[hholoubk]

@smitterl ... could you please review and accept?