Skip to content

Update SoftwareManager import path!#6883

Open
Anushree-Mathur wants to merge 1 commit into
autotest:masterfrom
Anushree-Mathur:software_manager
Open

Update SoftwareManager import path!#6883
Anushree-Mathur wants to merge 1 commit into
autotest:masterfrom
Anushree-Mathur:software_manager

Conversation

@Anushree-Mathur

@Anushree-Mathur Anushree-Mathur commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Fixing an ImportError caused by Avocado updating its internal structure. The SoftwareManager class has moved to the manager submodule.

Updated the import statement to reflect this relocation.
Signed-off-by: Anushree-Mathur anushree.mathur@linux.ibm.com

Summary by CodeRabbit

  • Chores
    • Updated internal test infrastructure imports for compatibility.

Fixes an ImportError caused by Avocado updating its internal structure.
The `SoftwareManager` class has moved to the `manager` submodule.

Updated the import statement to reflect this relocation.

Signed-off-by: Anushree-Mathur <anushree.mathur@linux.ibm.com>
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 85a001d4-11cf-4b2a-aeb4-61e88e1044c4

📥 Commits

Reviewing files that changed from the base of the PR and between c96ab65 and f077298.

📒 Files selected for processing (1)
  • libvirt/tests/src/cpu/powerpc_hmi.py

Walkthrough

This PR corrects the import path for SoftwareManager in the powerpc_hmi test file. The import statement is updated from avocado.utils.software_manager to avocado.utils.software_manager.manager to reference the correct module location. No test logic, control flow, or behavior is changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly references the main change: updating the SoftwareManager import path. It matches the PR objective of fixing an ImportError by updating the import statement.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Anushree-Mathur

Copy link
Copy Markdown
Contributor Author

All these testcase were failing without applying the patch

type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.normal.power8.tb_residue
→ ERROR: cannot import name 'SoftwareManager' from 'avocado.utils.software_manager'

type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.normal.power8.hdec_parity_error
→ ERROR: cannot import name 'SoftwareManager' from 'avocado.utils.software_manager'

type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.normal.power9.tb_residue
→ ERROR: cannot import name 'SoftwareManager' from 'avocado.utils.software_manager'

type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.normal.power9.hdec_parity_error
→ ERROR: cannot import name 'SoftwareManager' from 'avocado.utils.software_manager'

type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.with_save.power8.tb_residue
→ ERROR: cannot import name 'SoftwareManager' from 'avocado.utils.software_manager'

type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.with_save.power8.hdec_parity_error
→ ERROR: cannot import name 'SoftwareManager' from 'avocado.utils.software_manager'

type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.with_save.power9.tb_residue
→ ERROR: cannot import name 'SoftwareManager' from 'avocado.utils.software_manager'

type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.with_save.power9.hdec_parity_error
→ ERROR: cannot import name 'SoftwareManager' from 'avocado.utils.software_manager'

type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.with_suspend.power8.tb_residue
→ ERROR: cannot import name 'SoftwareManager' from 'avocado.utils.software_manager'

type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.with_suspend.power8.hdec_parity_error
→ ERROR: cannot import name 'SoftwareManager' from 'avocado.utils.software_manager'

type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.with_suspend.power9.tb_residue
→ ERROR: cannot import name 'SoftwareManager' from 'avocado.utils.software_manager'

type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.with_suspend.power9.hdec_parity_error
→ ERROR: cannot import name 'SoftwareManager' from 'avocado.utils.software_manager'

type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.power8_compatguest.power9.tb_residue
→ ERROR: cannot import name 'SoftwareManager' from 'avocado.utils.software_manager'

type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.power8_compatguest.power9.hdec_parity_error
→ ERROR: cannot import name 'SoftwareManager' from 'avocado.utils.software_manager'

After applying the patch all the testcases are moving forward from this error like

(2/3) type_specific.io-github-autotest-libvirt.powerpc_hmi.positive.normal.power8.tb_residue: CANCEL: Unsupported Host cpu version (41.91 s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant