Skip to content

migration: Skip vhostuser disk migration test on aarch64#6888

Open
hholoubk wants to merge 1 commit into
autotest:masterfrom
hholoubk:fix/aarch64-skip-vhostuser-disk-migration
Open

migration: Skip vhostuser disk migration test on aarch64#6888
hholoubk wants to merge 1 commit into
autotest:masterfrom
hholoubk:fix/aarch64-skip-vhostuser-disk-migration

Conversation

@hholoubk

@hholoubk hholoubk commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add no aarch64 to migration_with_vhostuser.cfg, matching the existing no ppc64le exclusion
  • RHEL qemu-kvm-*el*.aarch64 does not advertise vhost-user-blk, so the test always fails at VM define with "vhostuser disk is not supported with this QEMU binary"

Test plan

  • Verify avocado-vt lists migration.migration_with_disk.migration_with_vhostuser.with_precopy on x86_64
  • Verify the test is skipped on aarch64 (not listed / SKIP in CI)
  • Re-run cross_migration_cross_feature on aarch64 after merge — vhostuser error should disappear

Summary by CodeRabbit

  • Tests
    • Updated migration test configuration to exclude ARM-based architectures from disk migration scenarios.

RHEL aarch64 QEMU does not expose vhost-user-blk, so define fails with
"unsupported configuration: vhostuser disk is not supported with this
QEMU binary". Exclude aarch64 like ppc64le.

Assisted-by: Auto (Cursor Agent) (~90%)
Signed-off-by: hholoubk <hholoubk@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 878670ae-c981-4f41-b8d6-c9c1dac98671

📥 Commits

Reviewing files that changed from the base of the PR and between c96ab65 and f54491e.

📒 Files selected for processing (1)
  • libvirt/tests/cfg/migration/migration_with_disk/migration_with_vhostuser.cfg

Walkthrough

A single no aarch64 architecture exclusion directive is added to libvirt/tests/cfg/migration/migration_with_disk/migration_with_vhostuser.cfg at line 35. This causes the vhost-user disk migration test to be skipped when running on aarch64 architecture.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: adding an aarch64 architecture exclusion to a vhost-user disk migration test configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant