Use recreate_serial_console in BIOS boot tests#6889
Conversation
2fb5de6 to
b7b73f4
Compare
|
Warning Review limit reached
More reviews will be available in 58 minutes and 45 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Refactor BIOS boot order tests to use the recreate_serial_console parameter instead of manually calling cleanup_serial_console() and create_serial_console() before wait_for_serial_login(). This simplifies console management after VM boot operations, ensuring proper console state for various boot scenarios including OVMF and SeaBIOS. Modified test files: - bios/boot_order_ovmf.py: Console after VM start for OVMF boot testing - bios/boot_order_seabios.py: Console after VM start for SeaBIOS boot testing Both tests handle console recreation after VM start operations where the console needs to be reset to properly capture boot messages and login prompts. Total: 2 files modified with 9 fewer lines of console management code. Depends on: avocado-framework/avocado-vt#4248 Depends on: autotest#6596 Signed-off-by: hholoubk <hholoubk@redhat.com>
b7b73f4 to
3aff2ee
Compare
Refactor BIOS boot order tests to use the recreate_serial_console parameter
instead of manually calling cleanup_serial_console() and
create_serial_console() before wait_for_serial_login().
This simplifies console management after VM boot operations, ensuring
proper console state for various boot scenarios including OVMF and SeaBIOS.
Modified test files:
Both tests handle console recreation after VM start operations where the
console needs to be reset to properly capture boot messages and login prompts.
Total: 2 files modified with 9 fewer lines of console management code.
Depends on: avocado-framework/avocado-vt#4248 (Merged)
Depends on: #6890
Reopened from closed #6604 (rebased onto current master).