Skip to content

Refactor serial console sriov#6891

Open
hholoubk wants to merge 1 commit into
autotest:masterfrom
hholoubk:refactor-serial-console-sriov
Open

Refactor serial console sriov#6891
hholoubk wants to merge 1 commit into
autotest:masterfrom
hholoubk:refactor-serial-console-sriov

Conversation

@hholoubk

@hholoubk hholoubk commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Depends on: avocado-framework/avocado-vt#4248 (Merged)
Depends on: #6890

Reopened from closed #6597 (rebased onto current master).

@hholoubk
tests/sriov: Use recreate_serial_console in SR-IOV tests
1a038ad 
Refactor all SR-IOV tests to use recreate_serial_console parameter
instead of manually calling cleanup_serial_console() and
create_serial_console() before wait_for_serial_login().

This eliminates code duplication and makes the intent clearer across
all SR-IOV test categories: vIOMMU, VM lifecycle, device plug/unplug,
failover scenarios, and VFIO variant driver tests.

Modified test categories:
- vIOMMU tests (5 files): Device settings, DMA translation, address width, driver reload, hotplug
- VM lifecycle tests (5 files): Suspend/resume, reboot, managedsave, IOMMU+hostdev, exclusive check
- Plug/unplug tests (4 files): Released hostdev, interface/device attach/detach with flags, VFIO variant
- Failover tests (3 files): Migration, lifecycle operations, attach/detach hostdev
- VFIO tests (1 file): Migration with VFIO variant driver

Total: 18 files modified, cleaner code with single-line console recreation.

Depends on: avocado-framework/avocado-vt#4248
Depends on: autotest#6596

Signed-off-by: hholoubk <hholoubk@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@hholoubk, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 44 minutes and 34 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 15a9e35a-4786-4001-8a12-c49891f945cf

📥 Commits

Reviewing files that changed from the base of the PR and between c96ab65 and 1a038ad.

📒 Files selected for processing (18)
  • libvirt/tests/src/sriov/failover/sriov_failover_at_dt_hostdev.py
  • libvirt/tests/src/sriov/failover/sriov_failover_lifecycle.py
  • libvirt/tests/src/sriov/failover/sriov_failover_migration.py
  • libvirt/tests/src/sriov/plug_unplug/sriov_attach_detach_device_vfio_variant_driver.py
  • libvirt/tests/src/sriov/plug_unplug/sriov_attach_detach_device_with_flags.py
  • libvirt/tests/src/sriov/plug_unplug/sriov_attach_detach_interface_with_flags.py
  • libvirt/tests/src/sriov/plug_unplug/sriov_attach_released_hostdev.py
  • libvirt/tests/src/sriov/vIOMMU/hotplug_device_with_iommu_enabled.py
  • libvirt/tests/src/sriov/vIOMMU/intel_iommu_aw_bits.py
  • libvirt/tests/src/sriov/vIOMMU/intel_iommu_with_dma_translation.py
  • libvirt/tests/src/sriov/vIOMMU/iommu_device_settings.py
  • libvirt/tests/src/sriov/vIOMMU/viommu_unload_driver.py
  • libvirt/tests/src/sriov/vfio/sriov_migration_vfio_variant_driver.py
  • libvirt/tests/src/sriov/vm_lifecycle/sriov_vm_lifecycle_exclusive_check_running_domain.py
  • libvirt/tests/src/sriov/vm_lifecycle/sriov_vm_lifecycle_iommu_at_dt_hostdev.py
  • libvirt/tests/src/sriov/vm_lifecycle/sriov_vm_lifecycle_managedsave.py
  • libvirt/tests/src/sriov/vm_lifecycle/sriov_vm_lifecycle_reboot.py
  • libvirt/tests/src/sriov/vm_lifecycle/sriov_vm_lifecycle_suspend_resume.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hholoubk