Use recreate_serial_console in migration tests#6897
Conversation
Refactor all migration tests to use the recreate_serial_console parameter instead of manually calling cleanup_serial_console() and create_serial_console() before wait_for_serial_login(). This simplifies serial console management when switching connection URIs during migration operations. The pattern is especially useful after migrating VMs to remote hosts where the serial console needs to be recreated to match the new connection context. Modified test categories: - Memory migration tests: migrate_mem.py - Network migration tests: migrate_network.py (3 occurrences) - Migration with panic device: migrate_with_panic_device.py - Migration with virtiofs: internally/externally launched virtiofs devices (2 files) - Migration with vTPM: shared_tpm, vtpm_dev, external_tpm (3 files) All tests now use a cleaner pattern: vm.connect_uri = dest_uri vm_session = vm.wait_for_serial_login(timeout=240, recreate_serial_console=True) Total: 8 files modified with 31 fewer lines of console management code. Depends on: avocado-framework/avocado-vt#4248 Depends on: autotest#6596 Signed-off-by: hholoubk <hholoubk@redhat.com>
|
Warning Review limit reached
More reviews will be available in 44 minutes and 17 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Refactor migration tests to use the recreate_serial_console parameter
instead of manually calling cleanup_serial_console() and
create_serial_console() before wait_for_serial_login().
This simplifies console management when connecting to the migrated VM on the
destination host after switching the connection URI.
Modified test files across standard migration, vTPM, and virtiofs scenarios.
Depends on: avocado-framework/avocado-vt#4248 (Merged)
Depends on: #6890
Part of recreate_serial_console series (avocado-vt#4248). Rebased onto current master.