Adding testcases for cpu_modes along with vcpu plug-unplug!#6898
Adding testcases for cpu_modes along with vcpu plug-unplug!#6898Anushree-Mathur wants to merge 1 commit into
Conversation
|
Warning Review limit reached
More reviews will be available in 39 minutes and 55 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe pull request extends the Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@libvirt/tests/src/libvirt_vcpu_plug_unplug.py`:
- Around line 309-313: The code references xcepts.LibvirtXMLNotFoundError on
line 311 and VMCPUXML on line 313, but neither symbol is imported at the top of
the file. Add the missing imports: import the xcepts module (or the specific
LibvirtXMLNotFoundError exception from it) and import the VMCPUXML class. These
imports must be added to the imports section at the beginning of the
libvirt_vcpu_plug_unplug.py file to prevent NameError exceptions when the
exception handling code path is executed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4391f7bd-9edb-4cf2-bd06-910eed334919
📒 Files selected for processing (2)
libvirt/tests/cfg/libvirt_vcpu_plug_unplug.cfglibvirt/tests/src/libvirt_vcpu_plug_unplug.py
Add cpu_mode parameter to enable testing vcpu hotplug/unplug operations with different CPU modes (host-model, host-passthrough, custom) across various NUMA and hugepages configurations. This allows comprehensive testing of CPU hotplug functionality with different CPU configurations combined with memory topology variants. Additionally, normalize CPU model names to lowercase when using host-model to ensure consistent behavior across latest QEMU/libvirt versions. It is adding 10 more testcases. Signed-off-by: Anushree-Mathur <anushree.mathur@linux.ibm.com>
Anushree-Mathur
force-pushed
the
cpu_modes
branch
from
16c7ac4 to
9e94262
Compare
1 participant
Add cpu_mode parameter to enable testing vcpu hotplug/unplug operations with different CPU modes (host-model, host-passthrough, custom) across various NUMA and hugepages configurations. This allows comprehensive testing of CPU hotplug functionality with different CPU configurations combined with memory topology variants.
Additionally, normalize CPU model names to lowercase when using host-model to ensure consistent behavior across latest QEMU/libvirt versions.
It is adding 10 more testcases.
Signed-off-by: Anushree-Mathur anushree.mathur@linux.ibm.com
Summary by CodeRabbit