guest_os_booting: enable secure boot firmware feature on aarch64#6904
guest_os_booting: enable secure boot firmware feature on aarch64#6904hholoubk wants to merge 2 commits into
Conversation
Extend ovmf_firmware_feature enable_secure_boot to aarch64 using libvirt's uefi-vars varstore firmware path. Gate the variant on libvirt 12.1+ and QEMU 10.2+ where the feature is available. Assisted-by: Auto (Cursor) (~90%) Signed-off-by: hholoubk <hholoubk@redhat.com>
WalkthroughThe Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replace nested aarch64: condition with explicit only/no aarch64 variant split, matching disable_secure_boot and cartesian guest arch selection. Assisted-by: Auto (Cursor) (~90%) Signed-off-by: hholoubk <hholoubk@redhat.com>
Summary
guest_os_booting.ovmf_firmware_feature.positive_test.enable_secure_bootto aarch64QEMU_EFI.qemuvars.fd+vars.secboot.jsonvarstore) instead of pflash OVMFovmf_firmware_feature.pyviais_qemu_function_supported()Test plan
avocado run --vt-type libvirt guest_os_booting.ovmf_firmware_feature.positive_test.enable_secure_boot— should pass unchangedSummary by CodeRabbit
Release Notes