refactor(autoware_rviz_plugins): use autoware_ament_auto_package#35
Open
vish0012 wants to merge 1 commit intoautowarefoundation:mainfrom
Open
refactor(autoware_rviz_plugins): use autoware_ament_auto_package#35vish0012 wants to merge 1 commit intoautowarefoundation:mainfrom
vish0012 wants to merge 1 commit intoautowarefoundation:mainfrom
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 22
Lines ? 2573
Branches ? 306
======================================
Hits ? 0
Misses ? 2573
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
ament_auto_package()withautoware_ament_auto_package()for packages inautoware_rviz_pluginsthat emitted scoped header installation warnings during the clean build investigation.Updated packages:
autoware_perception_rviz_pluginautoware_planning_rviz_pluginHow was this PR tested?
Tested with:
colcon build --base-paths ~/autoware_scoped_headers/autoware/src --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_planning_rviz_plugin autoware_perception_rviz_pluginBoth target packages built successfully.
Notes for reviewers
This is part of the follow-up work after adding
USE_SCOPED_HEADER_INSTALL_DIRsupport toautoware_cmake.Effects on system behavior
No functional behavior change is intended. This updates the package macro to the Autoware wrapper for the scoped header migration work.