Skip to content

Fix for issue #16#18

Open
HeikoNitrobox wants to merge 4 commits intoavadev:mainfrom
HeikoNitrobox:main
Open

Fix for issue #16#18
HeikoNitrobox wants to merge 4 commits intoavadev:mainfrom
HeikoNitrobox:main

Conversation

@HeikoNitrobox
Copy link
Copy Markdown

Hi there,

I've fixed Issue#16.
If an Accept header is provided for document downloads, it will now be used; otherwise, it defaults to application/json.

I also migrated the existing tests to JUnit 5 and added new tests for this issue using WireMock.
Unfortunately, I wasn’t able to run the existing unit tests due to a missing .env file for Dotenv.
If possible, it would be great if you could add that file to the project.

Thanks!

@svc-developer
Copy link
Copy Markdown
Collaborator

@HeikoNitrobox Thank you for the PR - I will need to fix this in the core generator as the API file is generated each time we publish, so the changes will be overwritten. We will digest this and get it addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept header for downloadDocument is always set to application/json

2 participants