Skip to content

Propagate all setting about log capture to nested settings#383

Open
jansyk13 wants to merge 1 commit intoavast:mainfrom
jansyk13:nested_settings
Open

Propagate all setting about log capture to nested settings#383
jansyk13 wants to merge 1 commit intoavast:mainfrom
jansyk13:nested_settings

Conversation

@jansyk13
Copy link
Copy Markdown
Contributor

@jansyk13 jansyk13 commented Nov 9, 2022

No description provided.

@augi
Copy link
Copy Markdown
Member

augi commented Nov 9, 2022

The current behavior is documented here: https://github.com/avast/gradle-docker-compose-plugin/blob/main/README.md#nested-configurations

So at least, we should update the documentation.

But I'm not sure if it is a good idea to allow writing to the same file simultaneously 🤔 I'm fine with containerLogToDir but I would prefer to keep the rest (to prevent races when writing).

@augi
Copy link
Copy Markdown
Member

augi commented Aug 9, 2023

I´m afraid it would work correctly, to use the same file for writing from multiple threads 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants