Adding support for MULX instruction.#1199
Open
lvella wants to merge 1 commit into
Open
Conversation
1602afc to
bfb2ee6
Compare
bfb2ee6 to
b5cf7d6
Compare
Author
|
Apparently this works for very simple examples, both using the last operand from register and from memory. But it breaks the case I actually care about. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to implement the mulx instruction, but it is completely broken.
Whit this PR, the resulting c source from the file I am trying to decompile contains this broken typedef:
The functions containing mulx are output as return 0, instead of whatever the code it has. E.g.:
This particular file I am trying is the nasm output of https://github.com/powdr-labs/zkevm-prover/blob/26decaa2f6faa5367ca2eb24abfd2f23c0eb37fe/src/ffiasm/fr.asm
Can someone help me with it?