fix(naughty): honor beautiful.notification_border_width (fixes #3786)#4106
Open
JimmyCozza wants to merge 1 commit into
Open
fix(naughty): honor beautiful.notification_border_width (fixes #3786)#4106JimmyCozza wants to merge 1 commit into
JimmyCozza wants to merge 1 commit into
Conversation
…eWM#3786) The hardcoded default in naughty.config.defaults shadowed the theme variable. Move the dpi(1) fallback to the rendering sites so beautiful.notification_border_width is consulted first.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4106 +/- ##
=======================================
Coverage 90.42% 90.42%
=======================================
Files 940 941 +1
Lines 60290 60322 +32
Branches 1139 1139
=======================================
+ Hits 54516 54548 +32
Misses 5268 5268
Partials 506 506
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3786 —
beautiful.notification_border_widthis ignored becausenaughty.config.defaultscarries a hardcodedborder_width = dpi(1).The notification getter returns that default before the rendering code
checks the theme variable.
Remove
border_widthfrom the defaults table and add thedpi(1)fallback at the two rendering sites (
naughty.container.backgroundandnaughty.layout.legacy), after thebeautifullookup.Includes a regression test (
tests/test-naughty-border.lua) coveringtheme value, explicit override, and the
dpi(1)fallback.