Skip to content

Add formatting check and fix formatting #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AniruddhaKanhere wants to merge 1 commit into
base: main
Choose a base branch
from

fix: fix code formattng

b15e9e6
Select commit
Loading
Failed to load commit list.
Open

Add formatting check and fix formatting #1734

fix: fix code formattng
b15e9e6
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Oct 9, 2025 in 10s

87 new alerts including 2 medium severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

  • 2 medium

Other Alerts:

  • 1 warning
  • 84 notes

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 71 in src/integrationtests/java/com/aws/greengrass/integrationtests/e2e/mqttclient/MqttTest.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
MqttClient.subscribe
Loading
should be avoided because it has been deprecated.

Check notice on line 94 in src/integrationtests/java/com/aws/greengrass/integrationtests/e2e/mqttclient/MqttTest.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
MqttClient.subscribe
Loading
should be avoided because it has been deprecated.

Check notice on line 106 in src/integrationtests/java/com/aws/greengrass/integrationtests/e2e/mqttclient/MqttTest.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
MqttClient.subscribe
Loading
should be avoided because it has been deprecated.

Check notice on line 152 in src/integrationtests/java/com/aws/greengrass/integrationtests/e2e/mqttclient/MqttTest.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
MqttClient.subscribe
Loading
should be avoided because it has been deprecated.

Check notice on line 87 in src/main/java/com/aws/greengrass/builtin/services/lifecycle/LifecycleIPCEventStreamAgent.java

See this annotation in the file changed.

Code scanning / CodeQL

Exposing internal representation Note

getDeferUpdateFuturesMap exposes the internal representation stored in field deferUpdateFuturesMap. The value may be modified
after this call to getDeferUpdateFuturesMap
Loading
.

Check notice on line 92 in src/main/java/com/aws/greengrass/componentmanager/KernelConfigResolver.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
ObjectMapper.enable
Loading
should be avoided because it has been deprecated.

Check notice on line 88 in src/main/java/com/aws/greengrass/config/UpdateBehaviorTree.java

See this annotation in the file changed.

Code scanning / CodeQL

Exposing internal representation Note

getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.
getChildOverride exposes the internal representation stored in field childOverride. The value may be modified
after this call to getChildOverride
Loading
.

Check notice on line 514 in src/main/java/com/aws/greengrass/deployment/IotJobsHelper.java

See this annotation in the file changed.

Code scanning / CodeQL

Javadoc has impossible 'throws' tag Note

Javadoc for subscribeToGetNextJobDescription claims to throw ExecutionException but this is impossible.

Check notice on line 516 in src/main/java/com/aws/greengrass/deployment/IotJobsHelper.java

See this annotation in the file changed.

Code scanning / CodeQL

Javadoc has impossible 'throws' tag Note

Javadoc for subscribeToGetNextJobDescription claims to throw TimeoutException but this is impossible.

Check notice on line 589 in src/main/java/com/aws/greengrass/deployment/IotJobsHelper.java

See this annotation in the file changed.

Code scanning / CodeQL

Javadoc has impossible 'throws' tag Note

Javadoc for subscribeToEventNotifications claims to throw ExecutionException but this is impossible.

Check notice on line 591 in src/main/java/com/aws/greengrass/deployment/IotJobsHelper.java

See this annotation in the file changed.

Code scanning / CodeQL

Javadoc has impossible 'throws' tag Note

Javadoc for subscribeToEventNotifications claims to throw TimeoutException but this is impossible.

Check notice on line 36 in src/main/java/com/aws/greengrass/deployment/model/RunWith.java

See this annotation in the file changed.

Code scanning / CodeQL

Spurious Javadoc @param tags Note

@param tag "posixUser" does not match any actual parameter of method "toString()".
@param tag "posixUser" does not match any actual parameter of method "build()".
@param tag "posixUser" does not match any actual parameter of method "systemResourceLimits()".
@param tag "posixUser" does not match any actual parameter of method "windowsUser()".
@param tag "posixUser" does not match any actual parameter of method "builder()".
@param tag "posixUser" does not match any actual type parameter of type "RunWithBuilder".
@param tag "posixUser" does not match any actual parameter of constructor "RunWithBuilder()".

Check notice on line 85 in src/main/java/com/aws/greengrass/mqttclient/AwsIotMqttClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Exposing internal representation Note

getSubscriptionTopics exposes the internal representation stored in field subscriptionTopics. The value may be modified
after this call to getSubscriptionTopics
Loading
.
getSubscriptionTopics exposes the internal representation stored in field subscriptionTopics. The value may be modified
after this call to getSubscriptionTopics
Loading
.

Check notice on line 137 in src/main/java/com/aws/greengrass/mqttclient/MqttClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Exposing internal representation Note

getConnections exposes the internal representation stored in field connections. The value may be modified
after this call to getConnections
Loading
.
getConnections exposes the internal representation stored in field connections. The value may be modified
after this call to getConnections
Loading
.
getConnections exposes the internal representation stored in field connections. The value may be modified
after this call to getConnections
Loading
.
getConnections exposes the internal representation stored in field connections. The value may be modified
after this call to getConnections
Loading
.
getConnections exposes the internal representation stored in field connections. The value may be modified
after this call to getConnections
Loading
.
getConnections exposes the internal representation stored in field connections. The value may be modified
after this call to getConnections
Loading
.

Check notice on line 77 in src/main/java/com/aws/greengrass/mqttclient/WrapperMqttClientConnection.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
MqttClient.subscribe
Loading
should be avoided because it has been deprecated.

Check notice on line 23 in src/main/java/com/aws/greengrass/telemetry/AggregatedMetric.java

See this annotation in the file changed.

Code scanning / CodeQL

Exposing internal representation Note

AggregatedMetric exposes the internal representation stored in field value. The value may be modified
through the variable map
Loading
.
AggregatedMetric exposes the internal representation stored in field value. The value may be modified
through the variable map
Loading
.
AggregatedMetric exposes the internal representation stored in field value. The value may be modified
through the variable map
Loading
.
AggregatedMetric exposes the internal representation stored in field value. The value may be modified
through the variable map
Loading
.

Check notice on line 212 in src/main/java/com/aws/greengrass/util/GreengrassServiceClientFactory.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Builder.retryPolicy
Loading
should be avoided because it has been deprecated.

Check notice on line 54 in src/main/java/com/aws/greengrass/util/IamSdkClientFactory.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Builder.retryPolicy
Loading
should be avoided because it has been deprecated.

Check notice on line 128 in src/main/java/com/aws/greengrass/util/IotSdkClientFactory.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Builder.retryPolicy
Loading
should be avoided because it has been deprecated.

Check notice on line 53 in src/main/java/com/aws/greengrass/util/StsSdkClientFactory.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Builder.retryPolicy
Loading
should be avoided because it has been deprecated.

Check notice on line 18 in src/main/java/com/aws/greengrass/util/platforms/unix/UnixGroupAttributes.java

See this annotation in the file changed.

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
BasicAttributes.getPrincipalName
Loading
; it is advisable to add an Override annotation.

Check notice on line 19 in src/main/java/com/aws/greengrass/util/platforms/unix/UnixGroupAttributes.java

See this annotation in the file changed.

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
BasicAttributes.getPrincipalIdentifier
Loading
; it is advisable to add an Override annotation.

Check notice on line 214 in src/main/java/com/aws/greengrass/util/platforms/unix/UnixPlatform.java

See this annotation in the file changed.

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.

Check notice on line 21 in src/main/java/com/aws/greengrass/util/platforms/unix/UnixUserAttributes.java

See this annotation in the file changed.

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
BasicAttributes.getPrincipalName
Loading
; it is advisable to add an Override annotation.

Check notice on line 22 in src/main/java/com/aws/greengrass/util/platforms/unix/UnixUserAttributes.java

See this annotation in the file changed.

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
BasicAttributes.getPrincipalIdentifier
Loading
; it is advisable to add an Override annotation.