fix: strip macOS quarantine attribute from otel-helper shell wrapper#243
Open
jphuynh wants to merge 1 commit intoaws-solutions-library-samples:mainfrom
Open
fix: strip macOS quarantine attribute from otel-helper shell wrapper#243jphuynh wants to merge 1 commit intoaws-solutions-library-samples:mainfrom
jphuynh wants to merge 1 commit intoaws-solutions-library-samples:mainfrom
Conversation
xattr -d com.apple.quarantine was only applied to otel-helper-bin but not to the otel-helper shell wrapper copied alongside it. macOS propagates the quarantine flag to all downloaded files, causing the "Apple could not verify" Gatekeeper warning when otel-helper is invoked. This is a follow up from the previous PR: aws-solutions-library-samples#235 Tested on macOS successfully
Author
@scouturier @dineshSajwan This is a follow up from: #235 |
Contributor
|
Thanks @jphuynh ! I have reviewed it and it LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xattr -d com.apple.quarantine was only applied to otel-helper-bin but not to the otel-helper shell wrapper copied alongside it. macOS propagates the quarantine flag to all downloaded files, causing the "Apple could not verify" Gatekeeper warning when otel-helper is invoked.
This is a follow up from the previous PR: #235
Tested on macOS successfully
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.