Allow deployments using SSO profiles#789
Open
amendlik wants to merge 1 commit into
Open
Conversation
The previous logic verified that a profile exists by looking for the configuration value `aws_access_key_id`. This value only exists for for profiles with API keys, so it fails for SSO authenticated profiles. This commit uses the more generic `aws configure list` command to verify that the profile exists. The command returns 0 if the profile is present, and 255 if it is not.
Member
|
Thanks, @amendlik for contributing this PR. Sorry for the delay. We will review these changes and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous logic verified that a profile exists by looking for the configuration value
aws_access_key_id. This value only exists for for profiles with API keys, so it fails for SSO authenticated profiles.This commit uses the more generic
aws configure listcommand to verify that the profile exists. The command returns 0 if the profile is present, and 255 if it is not.Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.