Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(s3-deployment): add architecture property to BucketDeployment #37174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat(s3-deployment): add architecture property to BucketDeployment #37174
Changes from all commits
314fe57c017d5a5270b5c61578a25df0e4b2c5eb6add4bba8122c893df2b1f427f30842546147cf1491bFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-commands.js.snapshot/aws-cdk-codepipeline-commands.template.json
iam-role-root-principal-needs-conditions.guard
Raw output
Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards. Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/PipelineSourceCodePipelineActionRoleC6F9E7F5/Properties/AssumeRolePolicyDocument/Statement/0[L:590,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}]. Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/PipelineSourceCodePipelineActionRoleC6F9E7F5/Properties/AssumeRolePolicyDocument/Statement/0[L:590,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}]. Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/PipelineSourceCodePipelineActionRoleC6F9E7F5/Properties/AssumeRolePolicyDocument/Statement/0[L:590,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards. Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/PipelineComputeCommandsCodePipelineActionRole992CFF18/Properties/AssumeRolePolicyDocument/Statement/0[L:667,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}]. Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/PipelineComputeCommandsCodePipelineActionRole992CFF18/Properties/AssumeRolePolicyDocument/Statement/0[L:667,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}]. Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/PipelineComputeCommandsCodePipelineActionRole992CFF18/Properties/AssumeRolePolicyDocument/Statement/0[L:667,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards. Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/PipelineDeployDeployActionCodePipelineActionRole1C288A60/Properties/AssumeRolePolicyDocument/Statement/0[L:745,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}]. Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/PipelineDeployDeployActionCodePipelineActionRole1C288A60/Properties/AssumeRolePolicyDocument/Statement/0[L:745,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}]. Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/PipelineDeployDeployActionCodePipelineActionRole1C288A60/Properties/AssumeRolePolicyDocument/Statement/0[L:745,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-ec2-deploy-ssm-managed.js.snapshot/aws-cdk-codepipeline-ec2-deploy-ssm-managed-node.template.json
ec2-no-open-security-groups.guard
Raw output
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-ec2-deploy.js.snapshot/aws-cdk-codepipeline-ec2-deploy.template.json
ec2-no-open-security-groups.guard
Raw output
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-ecr-image-scan-action.js.snapshot/codepipeline-ecr-image-scan-action.template.json
iam-role-root-principal-needs-conditions.guard
Raw output
Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards. Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/PipelineSourceCodePipelineActionRoleC6F9E7F5/Properties/AssumeRolePolicyDocument/Statement/0[L:486,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}]. Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/PipelineSourceCodePipelineActionRoleC6F9E7F5/Properties/AssumeRolePolicyDocument/Statement/0[L:486,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}]. Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/PipelineSourceCodePipelineActionRoleC6F9E7F5/Properties/AssumeRolePolicyDocument/Statement/0[L:486,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards. Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/PipelineInvokeInspectorEcrImageScanActionCodePipelineActionRole3A92106F/Properties/AssumeRolePolicyDocument/Statement/0[L:545,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}]. Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/PipelineInvokeInspectorEcrImageScanActionCodePipelineActionRole3A92106F/Properties/AssumeRolePolicyDocument/Statement/0[L:545,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}]. Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/PipelineInvokeInspectorEcrImageScanActionCodePipelineActionRole3A92106F/Properties/AssumeRolePolicyDocument/Statement/0[L:545,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards. Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/PipelineDeployDeployActionCodePipelineActionRole1C288A60/Properties/AssumeRolePolicyDocument/Statement/0[L:621,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}]. Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/PipelineDeployDeployActionCodePipelineActionRole1C288A60/Properties/AssumeRolePolicyDocument/Statement/0[L:621,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}]. Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/PipelineDeployDeployActionCodePipelineActionRole1C288A60/Properties/AssumeRolePolicyDocument/Statement/0[L:621,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-eks-v2/test/integ.eks-cluster-imported.js.snapshot/aws-cdk-eks-import-cluster-test.template.json
iam-role-root-principal-needs-conditions.guard
Raw output
Check was not compliant as property [ArnEquals] is missing. Value traversed to [Path=/Resources/EksAdminRole1C96C514/Properties/AssumeRolePolicyDocument/Statement/0/Condition[L:318,C:27] Value={"ArnLike":{"aws:PrincipalArn":"arn:aws:iam::123456789012:role/cdk-*-cfn-exec-role-*"}}]. Check was not compliant as property [StringEquals] is missing. Value traversed to [Path=/Resources/EksAdminRole1C96C514/Properties/AssumeRolePolicyDocument/Statement/0/Condition[L:318,C:27] Value={"ArnLike":{"aws:PrincipalArn":"arn:aws:iam::123456789012:role/cdk-*-cfn-exec-role-*"}}].Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.