Skip to content

chore(apigateway): correct typos in comments#37268

Open
Koheki wants to merge 8 commits intoaws:mainfrom
Koheki:typo-apigateway
Open

chore(apigateway): correct typos in comments#37268
Koheki wants to merge 8 commits intoaws:mainfrom
Koheki:typo-apigateway

Conversation

@Koheki
Copy link
Copy Markdown

@Koheki Koheki commented Mar 17, 2026 •
edited
Loading

Issue # (if applicable)

N/A (no issue)

Reason for this change

Fixes a few typos/grammar issues in code comments.

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 17, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team March 17, 2026 07:08
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Mar 17, 2026
@pahud pahud mentioned this pull request Mar 17, 2026
Open
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 17, 2026
ozelalisen
ozelalisen previously approved these changes Mar 30, 2026
View reviewed changes
@ozelalisen ozelalisen self-assigned this Mar 30, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 30, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 30, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 30, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 31, 2026

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@pahud pahud mentioned this pull request Mar 31, 2026
Open
@badmintoncryer
Copy link
Copy Markdown
Contributor

badmintoncryer commented Mar 31, 2026

@Koheki Could you please resolve conflicts?

@mergify mergify bot dismissed ozelalisen’s stale review March 31, 2026 06:34

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 31, 2026
@badmintoncryer
Copy link
Copy Markdown
Contributor

badmintoncryer commented Mar 31, 2026

@ozelalisen Could you please approve this PR again?

ozelalisen
ozelalisen previously requested changes Apr 1, 2026
View reviewed changes
packages/aws-cdk-lib/aws-apigateway/lib/api-key.ts
Comment on lines -40 to +41
* @link https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-apikey.html#cfn-apigateway-apikey-name
* @default automically generated name
* @link http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-apikey.html#cfn-apigateway-apikey-name
* @default automatically generated name
Copy link
Copy Markdown
Member

@ozelalisen ozelalisen Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not related to this pr, i think you mistakenly added those after resolving merge conflict

Copy link
Copy Markdown
Author

@Koheki Koheki Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I fixed it!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 1, 2026
@mergify mergify bot dismissed ozelalisen’s stale review April 7, 2026 06:57

Pull request has been modified.

ozelalisen
ozelalisen previously approved these changes Apr 8, 2026
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 8, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed ozelalisen’s stale review April 11, 2026 09:05

Pull request has been modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ozelalisen ozelalisen ozelalisen left review comments

+1 more reviewer

@badmintoncryer badmintoncryer badmintoncryer approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@ozelalisen ozelalisen

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Koheki @aws-cdk-automation @badmintoncryer @ozelalisen