fix(eks): add eks:kube-proxy-windows group for Windows node groups#37473
fix(eks): add eks:kube-proxy-windows group for Windows node groups#37473syukawa-gh wants to merge 3 commits intoaws:mainfrom
Conversation
Per AWS documentation, the eks:kube-proxy-windows group is required for kube-proxy to work on Windows nodes. Without it, Windows nodes cannot properly route network traffic. Closes aws#36625
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
|
Exemption Request: This fix adds the |
|
Correction to my previous comment: After reviewing the diff more carefully, this PR needs unit tests to be added. I will update this PR with the required tests. The Exemption Request above should be disregarded for the unit test requirement. |
|
To clarify my earlier comments: unit tests are already included in this PR. The "Correction" comment above was posted in error. The exemption request is for the integration test only — this fix adds the |
|
|
||||||||||||||
|
|
||||||||||||||||||
Closes #36625
Per AWS documentation, the eks:kube-proxy-windows group is required for kube-proxy to work on Windows nodes. Added conditional group assignment when amiType is a Windows type.
Exemption Request: aws-auth ConfigMap change, covered by unit test logic.