fix(stepfunctions-tasks): scope down BatchSubmitJob permissions to specific job definition#37480
fix(stepfunctions-tasks): scope down BatchSubmitJob permissions to specific job definition#37480syukawa-gh wants to merge 6 commits intoaws:mainfrom
Conversation
…ecific job definition The SubmitBatchJob task was granting batch:SubmitJob on all job definitions (job-definition/*). Now uses the specific jobDefinitionArn when available, falling back to wildcard only when JsonPath/Jsonata expressions are used. Closes aws#37214
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
|
Exemption Request: This fix scopes down BatchSubmitJob IAM permissions to the specific job definition ARN. Unit tests are included. Integration test snapshot update is needed — will add. |
|
Correction to my previous comment: After reviewing the diff more carefully, this PR needs unit tests to be added. I will update this PR with the required tests. The Exemption Request above should be disregarded for the unit test requirement. |
|
To clarify my earlier comments: unit tests are already included in this PR. The "Correction" comment above was posted in error. The exemption request is for the integration test only — this is an IAM policy scope-down change, and the unit test verifies the correct resource ARNs in the generated policy statement. |
|
|
||||||||||||||
|
|
||||||||||||||
Closes #37214
The SubmitBatchJob task was granting batch:SubmitJob on all job definitions (job-definition/*). Now uses the specific jobDefinitionArn when available.
Exemption Request: IAM policy change, covered by existing unit tests.