chore(prlint): remove dead CLI integ test rule and label#37564
Open
vishaalmehrishi wants to merge 1 commit intomainfrom
Open
chore(prlint): remove dead CLI integ test rule and label#37564vishaalmehrishi wants to merge 1 commit intomainfrom
vishaalmehrishi wants to merge 1 commit intomainfrom
Conversation
vishaalmehrishi
temporarily deployed
to
automation
GitHub Actions
Inactive
vishaalmehrishi
temporarily deployed
to
automation
GitHub Actions
Inactive
vishaalmehrishi
temporarily deployed
to
automation
GitHub Actions
Inactive
vishaalmehrishi
force-pushed
the
chore/remove-dead-cli-integ-test-rule
branch
from
21d0824 to
13de6c8
Compare
vishaalmehrishi
temporarily deployed
to
automation
GitHub Actions
Inactive
vishaalmehrishi
temporarily deployed
to
automation
GitHub Actions
Inactive
vishaalmehrishi
temporarily deployed
to
automation
GitHub Actions
Inactive
vishaalmehrishi
temporarily deployed
to
automation
GitHub Actions
Inactive
The CDK CLI was extracted to aws/aws-cdk-cli, so `packages/aws-cdk/lib/` no longer exists in this repo. The `noCliChanges` linter rule, `CLI_INTEG_TESTED` exemption label, and the PR comment asking maintainers to add the label were all dead code. - Remove `noCliChanges` function and its validation rule - Remove `CLI_INTEG_TESTED` from Exemption enum - Remove the comment step from request-cli-integ-test workflow (pipeline push to test-main-pipeline is unchanged) - Remove associated tests and README entry
vishaalmehrishi
force-pushed
the
chore/remove-dead-cli-integ-test-rule
branch
from
13de6c8 to
d6c4cae
Compare
vishaalmehrishi
temporarily deployed
to
automation
GitHub Actions
Inactive
vishaalmehrishi
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
added
the
pr/needs-maintainer-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
The CDK CLI was extracted to aws/aws-cdk-cli, so
packages/aws-cdk/lib/no longer exists in this repo. ThenoCliChangesPR linter rule checked for changes in that path, meaning it could never fire. Thepr-linter/cli-integ-testedexemption label and the workflow comment (example) asking maintainers to add it were dead code.Description of changes
noCliChangesfunction and its validation rule fromlint.tsCLI_INTEG_TESTEDfrom theExemptionenum inconstants.tsrequest-cli-integ-test.ymlworkflow (the pipeline push totest-main-pipelineis unchanged — it still runs forfeatures.tschanges)Description of how you validated changes
Confirmed
packages/aws-cdk/lib/does not exist in the repo. Grep for all references toCLI_INTEG_TESTED,cli-integ-tested, andnoCliChanges— all removed or in generated.js/.d.tsfiles that will be regenerated on build.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license