Tighten file permissions when writing credentials in CodeArtifact#10192
Merged
AndrewAsseily merged 1 commit intoaws:v2from Apr 8, 2026
Merged
Tighten file permissions when writing credentials in CodeArtifact#10192AndrewAsseily merged 1 commit intoaws:v2from
AndrewAsseily merged 1 commit intoaws:v2from
Conversation
AndrewAsseily
changed the title
Contributor
|
Thanks! |
FiveSlashNine
force-pushed
the
v2
branch
2 times, most recently
from
3064dde to
465bf6f
Compare
Contributor
Author
|
Added the changelog entry but I need to skip the tests for windows |
Contributor
Author
|
Added an annotation to skip the tests for windows |
Contributor
Author
|
The other pr had failures, most likely because I pass fd to chmod instead of the path. I will change it and push again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change updates the CodeArtifact login credential file operations to use secure file permissions (0o600) by replacing standard open() calls with os.open() and os.fdopen(). This prevents credentials in .netrc and .pypirc files from being created with default permissions that could expose them to unauthorized users on the system.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.