Fix source builds failing when the interpreter's bundled pip differs from the pip in the build environment - #10595
Merged
Merged
Conversation
…from the pip in the build environment
AndrewAsseily
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Addresses recent CI failures such as https://github.com/aws/aws-cli/actions/runs/32518930302/job/96886679998#step:5:910
Description of changes: Our source installation tests have been failing recently on the Ubuntu runners which I believe is related to a recent Python/pip upgrade in the images.
When doing the source installation in to a venv via
system-sandbox, the venv is initially created containing the Python interpreter's pip version. We then copy our pinned version of pip over it, overwriting existing files, but not removing any files that were removed between pip versions. This led to anImportErrorwithin pip's code.Now, when we're copying the CLI's pinned dependencies into the venv, we first remove any directories for dependencies that are initially in the venv. This avoids this mix of versions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.