Conversation
davidh44
approved these changes
Jun 6, 2025
Contributor
davidh44
left a comment
davidh44
left a comment
There was a problem hiding this comment.
Looks good, just need a a changelog
zoewangg
requested changes
Jun 6, 2025
Contributor
zoewangg
left a comment
zoewangg
left a comment
There was a problem hiding this comment.
Don't we need to update account ID code path to use this new method?
Contributor
Author
Separate internal Arn class used in endpoints logic already returns Optional |
RanVaknin
force-pushed
the
rvaknin/better-arn-parsing
branch
from
b5c8985 to
0b61c58
Compare
|
zoewangg
approved these changes
Jun 13, 2025
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Addresses #6108 .
Currently the SDK uses exceptions as control flow for arn parsing. This is an anti pattern in Java and can cause performance overhead.
Modifications
This PR adds another arn parsing method
tryFromString(arn)that would return an Optional of Arn when the arn is valid, and an empty when it is invalid - this avoids the hot path of throwing exceptions as control flow.Testing
Unit tests: