-
Notifications
You must be signed in to change notification settings - Fork 723
feat: Add full-featured Iceberg MERGE INTO conditional merges support and argument validation #3201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pedrorfdez
wants to merge
23
commits into
aws:main
Choose a base branch
from
pedrorfdez:feature/iceberg-merge-into-full-functionality
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+330
−31
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
21bfee0
Added necesary parameters to 'to_iceberg' method to expand functionality
pedrorfdez d58094e
Removed unused import
pedrorfdez 9072ac5
Added validation for new parameters complying with new logic
pedrorfdez 4aa6eb1
Draft implementation done. Pending tests and verify optimal approach
pedrorfdez 0a8861f
Added additional validation and removed unhandled action.
pedrorfdez 556094e
Added new params to python docstrings
pedrorfdez 5d03da1
Fixed backslash in f-string
pedrorfdez 93c9698
Added tests
pedrorfdez 802b485
Updated stringdocs
pedrorfdez b32db8b
fix: ruff reformat
pedrorfdez 395b798
refactor: _validate_args refactor to comply with ruff check
pedrorfdez ba9c522
reformat: small reformat
pedrorfdez 04ad6e9
refactor: fix mypy typecheck errors
pedrorfdez 7592357
fix: replace truthiness check with explicit None comparison
pedrorfdez 3cdbe2c
fix: conditional merge happy path to use Int64 to match athena's read…
pedrorfdez fece82e
reformat: ruff
pedrorfdez 953f887
fix: in happy path test case, convert pandas StringDType to string (o…
pedrorfdez f9255aa
re-run workflow
pedrorfdez 98e9f5b
refactor: add helper function '_validate_merge_conditional_clauses'
pedrorfdez 23ccfb7
reformat: ruff formatting
pedrorfdez f6870b3
fix: case-insensitive when and action clauses in _merge_iceberg
pedrorfdez 7b00a35
test: add test case to evaluate case insensitive when and action clau…
pedrorfdez 7f854cd
Merge branch 'main' into feature/iceberg-merge-into-full-functionality
kukushking File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.