Skip to content

feat(emr): support bootstrap arguments in create_cluster#3265

Open
omwanere wants to merge 11 commits intoaws:mainfrom
omwanere:fix-bootstrap-args
Open

feat(emr): support bootstrap arguments in create_cluster#3265
omwanere wants to merge 11 commits intoaws:mainfrom
omwanere:fix-bootstrap-args

Conversation

@omwanere
Copy link
Copy Markdown

@omwanere omwanere commented Jan 24, 2026 •
edited
Loading

Fixes #3191

  • Added support for bootstrap actions with additional args
  • Introduced new bootstraps parameter accepting str or dict configs
  • Maintained backward compatibility with bootstraps_paths
  • Added unit tests for both formats
  • Note: Unit tests updated to include required subnet_id parameter.

@kukushking
Copy link
Copy Markdown
Contributor

kukushking commented Jan 24, 2026

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: ea0a3bf
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Copy Markdown
Contributor

kukushking commented Jan 24, 2026

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 51003fc
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@omwanere omwanere changed the title Add support for bootstrap arguments in EMR create_cluster emr: support bootstrap arguments in create_cluster Jan 24, 2026
@omwanere omwanere changed the title emr: support bootstrap arguments in create_cluster EMR: Support bootstrap arguments in create_cluster Jan 24, 2026
@omwanere omwanere changed the title EMR: Support bootstrap arguments in create_cluster Support bootstrap arguments in create_cluster Jan 24, 2026
@omwanere omwanere changed the title Support bootstrap arguments in create_cluster feat(emr): support bootstrap arguments in create_cluster Jan 24, 2026
@kukushking
Copy link
Copy Markdown
Contributor

kukushking commented Jan 24, 2026

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: c0b3de3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Copy Markdown
Contributor

kukushking commented Jan 24, 2026

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 25d1de3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Copy Markdown
Contributor

kukushking commented Jan 24, 2026

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: b2ca42e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Copy Markdown
Contributor

kukushking commented Jan 24, 2026

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 7e046e7
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Copy Markdown
Contributor

kukushking commented Jan 24, 2026

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: f006dde
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Copy Markdown
Contributor

kukushking commented Jan 25, 2026

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 86d1581
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Copy Markdown
Contributor

kukushking commented Jan 25, 2026

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 114a171
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Copy Markdown
Contributor

kukushking commented Jan 25, 2026

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 4e9bc87
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Copy Markdown
Contributor

kukushking commented Jan 25, 2026

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 63e3838
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

duoan
duoan reviewed Feb 24, 2026
View reviewed changes
awswrangler/emr.py
Comment on lines +352 to +355
else:
raise TypeError("Each bootstrap must be a string or a dict.")

args["BootstrapActions"] = bootstrap_actions
Copy link
Copy Markdown

@duoan duoan Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already Raised error, the line #335 should never be executed.

duoan
duoan reviewed Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown

@duoan duoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add more comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@duoan duoan duoan left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EMR create_cluster support pass bootstrap arguments

3 participants

@omwanere @kukushking @duoan