Test labeling gate#140
Closed
reyhankoyun wants to merge 10 commits intoaws:mainfrom
reyhankoyun:test-labeling-gate
Closed
Test labeling gate#140reyhankoyun wants to merge 10 commits intoaws:mainfrom reyhankoyun:test-labeling-gate
reyhankoyun wants to merge 10 commits intoaws:mainfrom
reyhankoyun:test-labeling-gate
Conversation
- Add integration-tests.yml workflow with OIDC authentication and pull_request_target - Support team member detection and safe-to-test label for external contributors - Remove #[ignore] annotations from all 6 integration tests - Add dynamic port allocation using atomic counter to prevent port conflicts - Add proper randomness to secret naming (thread ID + nanoseconds + random number) - Add fastrand dependency for random number generation - Update test-local.sh to remove --ignored flag and update comments - Enable both sequential (--test-threads=1) and parallel test execution
Use 'safe to test' (with spaces) to align with other AWS repositories
- COLLABORATOR: automatic test execution - Others: require 'safe to test' label for manual approval - Remove repo source checks - only author trust level matters
- Add reopened trigger (part of default set) - Add ready_for_review trigger for draft PRs marked ready - Add Checkout step name for consistency
- test_cache_hit_behavior: Verifies cache hits are faster than AWS calls - test_refresh_now_bypasses_cache: Confirms refreshNow=true bypasses cache - test_cache_after_secret_update: Tests stale cache behavior after secret updates - test_real_ttl_expiration_timing: Validates TTL expiration and cache refresh - test_ttl_zero_disables_caching: Ensures TTL=0 disables caching completely These tests cover all critical caching behaviors that cannot be unit tested, including timing-based assertions and AWS integration scenarios.
- Updated caching.rs to only include true integration tests: - test_cache_after_secret_update: Real AWS secret rotation + cache staleness - test_real_ttl_expiration_timing: Real time-based TTL with actual delays - Removed performance-focused tests (moved to future performance suite) - Removed parameter behavior tests (moved to future unit tests) - Fixed GitHub Actions security vulnerability: - Changed pull_request_target to only trigger on 'labeled' events - Eliminates race condition where unapproved code could execute with AWS credentials - Each commit now requires explicit human approval via safe-to-test label - Auto-removes label after use to prevent persistent approval Integration tests now focus on real AWS interactions and timing behavior that cannot be effectively mocked or measured in unit tests.
This PR tests the security gate that requires safe-to-test label before integration tests can run with AWS credentials.
reyhankoyun
added
the
safe-to-test
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 14 14
Lines 2418 2418
Branches 2418 2418
=======================================
Hits 2218 2218
Misses 150 150
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.