Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 91.88% 92.14% +0.25%
==========================================
Files 14 14
Lines 2404 2405 +1
Branches 2404 2405 +1
==========================================
+ Hits 2209 2216 +7
+ Misses 147 143 -4
+ Partials 48 46 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
simonmarty
left a comment
There was a problem hiding this comment.
It looks like the upload is not succeeding with
Warning: No files were found with the provided path: aws_secretsmanager_caching/target/criterion/. No artifacts will be uploaded.
…results aren't generated
ThirdEyeSqueegee
left a comment
There was a problem hiding this comment.
The Criterion book has a section about benchmarking async functions. Did we take this into consideration when writing these tests? Not sure how it plays with Tokio.
Yes, we're already implementing Criterion's async benchmarking pattern for Tokio. |
- Download previous benchmark results before running benchmarks - Use branch-based artifact naming for baseline comparison - Add continue-on-error for first runs without baseline - Enables automatic performance regression detection across runs
7438445 to
969e781
Compare
94614bb to
e6ea6f4
Compare
This reverts commit 7438445.
Issue #, if available:
Description of changes:
This PR builds off of PR #122 and creates a benchmark workflow similar to integration tests workflow that runs the benchmarks added in PR #122
Add two basic benchmarks
Using criterion (used by the AWS SDK for Rust).
This hopefully will serve to catch performance regressions in future code changes and open the door to profiling.
Successful run from fork: https://github.com/reyhankoyun/aws-secretsmanager-agent/actions/runs/20082405961/job/57612354790
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.