Skip to content

revert workflow change#5854

Open
sirutBuasai wants to merge 1 commit intomainfrom
revert-sanitry
Open

revert workflow change#5854
sirutBuasai wants to merge 1 commit intomainfrom
revert-sanitry

Conversation

@sirutBuasai
Copy link
Copy Markdown
Member

Purpose

Test Plan

Test Result


Toggle if you are merging into master Branch

By default, docker image builds and tests are disabled. Two ways to run builds and tests:

  1. Using dlc_developer_config.toml
  2. Using this PR description (currently only supported for PyTorch, TensorFlow, vllm, and base images)
How to use the helper utility for updating dlc_developer_config.toml

Assuming your remote is called origin (you can find out more with git remote -v)...

  • Run default builds and tests for a particular buildspec - also commits and pushes changes to remote; Example:

python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp origin

  • Enable specific tests for a buildspec or set of buildspecs - also commits and pushes changes to remote; Example:

python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp origin

  • Restore TOML file when ready to merge

python src/prepare_dlc_dev_environment.py -rcp origin

NOTE: If you are creating a PR for a new framework version, please ensure success of the local, standard, rc, and efa sagemaker tests by updating the dlc_developer_config.toml file:

  • sagemaker_remote_tests = true
  • sagemaker_efa_tests = true
  • sagemaker_rc_tests = true
  • sagemaker_local_tests = true
How to use PR description Use the code block below to uncomment commands and run the PR CodeBuild jobs. There are two commands available:
  • # /buildspec <buildspec_path>
    • e.g.: # /buildspec pytorch/training/buildspec.yml
    • If this line is commented out, dlc_developer_config.toml will be used.
  • # /tests <test_list>
    • e.g.: # /tests sanity security ec2
    • If this line is commented out, it will run the default set of tests (same as the defaults in dlc_developer_config.toml): sanity, security, ec2, ecs, eks, sagemaker, sagemaker-local.
# /buildspec <buildspec_path>
# /tests <test_list>
Toggle if you are merging into main Branch

PR Checklist

  • [] I ran pre-commit run --all-files locally before creating this PR. (Read DEVELOPMENT.md for details).

Signed-off-by: sirutBuasai <sirutbuasai27@outlook.com>
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added authorized Size:XS Determines the size of the PR labels Mar 30, 2026
@sirutBuasai sirutBuasai enabled auto-merge (squash) March 30, 2026 20:00
@kazisufiyan-k2
Copy link
Copy Markdown

Purpose

Test Plan

Test Result

Toggle if you are merging into master Branch

Toggle if you are merging into main Branch

This PR updates multiple GitHub Actions workflows by re-enabling certain workflow triggers and test paths that were previously commented out. The changes ensure that workflows are triggered correctly when relevant files are modified.

🔧 What Changed

Across all 4 workflow files:

Uncommented workflow trigger paths like:
.github/workflows/...
test/sanity/**
Ensured telemetry-related tests are included:
test/telemetry/**
Added or maintained specific test paths:
test/sglang/sagemaker/**
test/vllm/sagemaker/**
Workflow files now properly listen to their own changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authorized Size:XS Determines the size of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants