Xgboost migration - Add generate-release-spec and release-image steps to XGBoost SageMaker release workflow#5862
Open
bhanutejagk wants to merge 30 commits intomainfrom
Open
Xgboost migration - Add generate-release-spec and release-image steps to XGBoost SageMaker release workflow#5862bhanutejagk wants to merge 30 commits intomainfrom
bhanutejagk wants to merge 30 commits intomainfrom
Conversation
d30f906 to
47a0c75
Compare
added 2 commits
March 31, 2026 17:34
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 12 X-AI-Prompt: add these lines in release-sagemaker-xgboost to truigger # TODO: Remove push trigger after testing, keep only workflow_dispatch push: branches: [xgboost-release]
feat: Add push trigger on xgboost-release branch for release testing Add a temporary push trigger on the xgboost-release branch to the release workflow so it can be tested end-to-end without manual workflow_dispatch. This trigger should be removed after testing. ai-dev-branch commit IDs: 4f856af The prompts used are captured in the footers of those commits. The initial prompt was: add these lines in release-sagemaker-xgboost to truigger # TODO: Remove push trigger after testing, keep only workflow_dispatch --- X-AI-Handle-Time-Seconds: 12 X-AI-Line-Changes: New:3, Altered:0, Deleted:0 X-Human-Line-Changes: New:0, Altered:0, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:3, Altered:0, Deleted:0 X-AI-Handle-Time-Seconds-Kiro-cli: 12 X-AI-Change-Count: 1 X-Human-Change-Count: 0 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: false
47a0c75 to
84a4df6
Compare
added 4 commits
March 31, 2026 17:37
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 53 X-AI-Prompt: no this has made a mess now the pr contains only that changes of 2 lines
feat: Add release pipeline for XGBoost SageMaker gamma testing Add generate-release-spec and release-image jobs to the XGBoost SageMaker release workflow, modeled after the vLLM auto-release workflow. The generate-release-spec job gates on unit-test and security-test, checks if release is enabled in config, then generates the release spec. The release-image job calls the reusable-release-image workflow with the environment from config. Benchmark tests are commented out since they already passed in PR #5852. Also set public_registry to false since xgboost uses private ECR only. ai-dev-branch commit IDs: bd34e9a The prompts used are captured in the footers of those commits. The initial prompt was: no this has made a mess now the pr contains only that changes of 2 lines --- X-AI-Handle-Time-Seconds: 53 X-AI-Line-Changes: New:41, Altered:38, Deleted:0 X-Human-Line-Changes: New:0, Altered:0, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:41, Altered:38, Deleted:0 X-AI-Handle-Time-Seconds-Kiro-cli: 53 X-AI-Change-Count: 1 X-Human-Change-Count: 0 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: false
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 14 X-AI-Prompt: okay make chagne to xgbost-migration brnach not release since our branch is migration not release
fix: Change release workflow push trigger branch to xgboost-migration Update the push trigger branch from xgboost-release to xgboost-migration to match the actual development branch name, so the release workflow triggers on push to the correct branch. ai-dev-branch commit IDs: c7c958a The prompts used are captured in the footers of those commits. The initial prompt was: okay make chagne to xgbost-migration brnach not release since our branch is migration not release --- X-AI-Handle-Time-Seconds: 14 X-AI-Line-Changes: New:0, Altered:1, Deleted:0 X-Human-Line-Changes: New:0, Altered:0, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:0, Altered:1, Deleted:0 X-AI-Handle-Time-Seconds-Kiro-cli: 14 X-AI-Change-Count: 1 X-Human-Change-Count: 0 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: false
added 2 commits
April 1, 2026 14:47
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 9 X-AI-Prompt: yeah set it
chore: Set force_release true to bypass change control for gamma testing Set force_release to true in sagemaker-xgboost config to bypass the AWS ADVISORY change control block on us-northeast-1 which is incorrectly blocking us-west-2 gamma releases. ai-dev-branch commit IDs: 643f139 The prompts used are captured in the footers of those commits. The initial prompt was: yeah set it --- X-AI-Handle-Time-Seconds: 9 X-AI-Line-Changes: New:0, Altered:1, Deleted:0 X-Human-Line-Changes: New:0, Altered:0, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:0, Altered:1, Deleted:0 X-AI-Handle-Time-Seconds-Kiro-cli: 9 X-AI-Change-Count: 1 X-Human-Change-Count: 0 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: false
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 37 X-AI-Prompt: Do not remove anything our changes are to just add the release image and generate release spec and the rest should not be changed what is in the main. i know previously we commented out the benchmark teests but recent chnages in repo already handled that so now we have to just add last 2 steps without changeing any thing
feat: Merge main and add generate-release-spec and release-image jobs Merge latest main into xgboost-migration and add the generate-release-spec and release-image jobs to the release workflow. All other changes from main are preserved as-is. ai-dev-branch commit IDs: 48062a6 The prompts used are captured in the footers of those commits. The initial prompt was: Do not remove anything our changes are to just add the release image and generate release spec and the rest should not be changed what is in the main. --- X-AI-Handle-Time-Seconds: 37 X-AI-Line-Changes: New:1967, Altered:135, Deleted:0 X-Human-Line-Changes: New:0, Altered:0, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:1967, Altered:135, Deleted:0 X-AI-Handle-Time-Seconds-Kiro-cli: 37 X-AI-Change-Count: 1 X-Human-Change-Count: 0 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: false
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 33 X-AI-Prompt: i want to test just the release logic comment the tests which might take hours to run
chore: Comment out tests to isolate release logic testing Comment out unit-test, security-test, and xgboost-tests jobs to speed up release logic iteration. generate-release-spec now depends only on load-config and build-image. ai-dev-branch commit IDs: 2084b30 The prompts used are captured in the footers of those commits. The initial prompt was: i want to test just the release logic comment the tests which might take hours to run --- X-AI-Handle-Time-Seconds: 33 X-AI-Line-Changes: New:0, Altered:62, Deleted:2 X-Human-Line-Changes: New:0, Altered:0, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:0, Altered:62, Deleted:2 X-AI-Handle-Time-Seconds-Kiro-cli: 33 X-AI-Change-Count: 1 X-Human-Change-Count: 0 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: false
added 2 commits
April 8, 2026 23:43
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 38 X-AI-Prompt: no i created a new GitHub environment preprod and now make changees to make it possible
feat: Add preprod environment support and switch xgboost to preprod Add preprod as a valid environment in reusable-release-image.yml validation. Switch xgboost config to environment: preprod to test release to preprod account 857753979684 in us-east-2. ai-dev-branch commit IDs: 5ec9496 The prompts used are captured in the footers of those commits. The initial prompt was: no i created a new GitHub environment preprod and now make changees to make it possible --- X-AI-Handle-Time-Seconds: 38 X-AI-Line-Changes: New:0, Altered:3, Deleted:0 X-Human-Line-Changes: New:0, Altered:0, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:0, Altered:3, Deleted:0 X-AI-Handle-Time-Seconds-Kiro-cli: 38 X-AI-Change-Count: 1 X-Human-Change-Count: 0 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: false
added 2 commits
April 9, 2026 00:25
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 13 X-AI-Prompt: change env to gamma i want to trigger
chore: Switch environment back to gamma ai-dev-branch commit IDs: 2f85fab The prompts used are captured in the footers of those commits. The initial prompt was: change env to gamma i want to trigger --- X-AI-Handle-Time-Seconds: 13 X-AI-Line-Changes: New:0, Altered:1, Deleted:0 X-Human-Line-Changes: New:0, Altered:0, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:0, Altered:1, Deleted:0 X-AI-Handle-Time-Seconds-Kiro-cli: 13 X-AI-Change-Count: 1 X-Human-Change-Count: 0 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: false
added 2 commits
April 9, 2026 00:31
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 12 X-AI-Prompt: change back to preprod
chore: Switch environment to preprod ai-dev-branch commit IDs: 8723b2f The prompts used are captured in the footers of those commits. The initial prompt was: change back to preprod --- X-AI-Handle-Time-Seconds: 12 X-AI-Line-Changes: New:0, Altered:1, Deleted:0 X-Human-Line-Changes: New:0, Altered:0, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:0, Altered:1, Deleted:0 X-AI-Handle-Time-Seconds-Kiro-cli: 12 X-AI-Change-Count: 1 X-Human-Change-Count: 0 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Toggle if you are merging into master Branch
By default, docker image builds and tests are disabled. Two ways to run builds and tests:
How to use the helper utility for updating dlc_developer_config.toml
Assuming your remote is called
origin(you can find out more withgit remote -v)...python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp originpython src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp originpython src/prepare_dlc_dev_environment.py -rcp originNOTE: If you are creating a PR for a new framework version, please ensure success of the local, standard, rc, and efa sagemaker tests by updating the dlc_developer_config.toml file:
sagemaker_remote_tests = truesagemaker_efa_tests = truesagemaker_rc_tests = truesagemaker_local_tests = trueHow to use PR description
Use the code block below to uncomment commands and run the PR CodeBuild jobs. There are two commands available:# /buildspec <buildspec_path># /buildspec pytorch/training/buildspec.yml# /tests <test_list># /tests sanity security ec2sanity, security, ec2, ecs, eks, sagemaker, sagemaker-local.Toggle if you are merging into main Branch
PR Checklist
pre-commit run --all-fileslocally before creating this PR. (Read DEVELOPMENT.md for details).