Add --system-store-location flag to configure Windows certificate sto…#166
Open
nas-ttatewaki wants to merge 1 commit intoaws:mainfrom
Open
Add --system-store-location flag to configure Windows certificate sto…#166nas-ttatewaki wants to merge 1 commit intoaws:mainfrom
nas-ttatewaki wants to merge 1 commit intoaws:mainfrom
Conversation
nas-ttatewaki
force-pushed
the
feature/windows-cert-store-location
branch
from
9074170 to
d3b46ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…re location
Issue #, if available:
Fixes #70
Description of changes:
The Windows certificate store search was hardcoded to use the
CERT_SYSTEM_STORE_CURRENT_USERcontext. Since theLocalMachine\MYstore is not inherited intoCurrentUser\MY, users who store certificates in the Local Machine personal store had no way to access them directly.This PR adds a
--system-store-locationflag that acceptsCurrentUser(default) orLocalMachine, allowing users to specify which store context to search. The flag is available on thecredential-process,sign-string, andread-certificate-datacommands. Input is validated and normalized (case-insensitive), following the existing--system-store-namepattern.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.