fix(serve): graceful shutdown on SIGTERM/SIGINT (exit 0)#177
Open
fix(serve): graceful shutdown on SIGTERM/SIGINT (exit 0)#177
Conversation
The serve command previously called os.Exit(2) when receiving SIGTERM, which caused Kubernetes to report the sidecar container as errored even when the pod completed successfully. This change adds a signal handler that: - Catches SIGTERM and SIGINT - Calls server.Shutdown() with a 5s context for in-flight requests - Lets Serve() return naturally via http.ErrServerClosed → exit 0 Fixes: aws#176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
servecommand has no signal handler. When Kubernetes sendsSIGTERMto the container (e.g. during pod shutdown, rolling update, or job completion
with native sidecars), Go's default signal handling terminates the process
with exit code 2.
This causes Kubernetes to report the sidecar container as
reason: Erroreven when the pod/job completed successfully. See issue #176.
Fix
Add a signal handler in
Serve()that:SIGTERMandSIGINTon a buffered channelserver.Shutdown()with a 5-second context to allow in-flight requests to completeServe()viahttp.ErrServerClosed→ exit code 0Testing
Fixes #176