feature: Feat: Feature Store in Sagemaker SDK v3 (5496)#5716
Draft
aviruthen wants to merge 1 commit intoaws:masterfrom
Draft
feature: Feat: Feature Store in Sagemaker SDK v3 (5496)#5716aviruthen wants to merge 1 commit intoaws:masterfrom
aviruthen wants to merge 1 commit intoaws:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feature Store already exists in SDK V3 under sagemaker-mlops at sagemaker.mlops.feature_store with a comprehensive migration guide. The issue is discoverability: (1) the sagemaker.mlops.init.py doesn't mention or re-export feature_store, (2) the init.py imports FeatureGroup and FeatureMetadata from core but does NOT import FeatureStore (needed for search()), (3) the create_dataset() convenience function referenced in the MIGRATION_GUIDE.md doesn't actually exist in feature_utils.py or anywhere else, (4) there is no top-level documentation or entry point directing users to the new location. The fix involves: exposing feature_store in the mlops init.py, adding the missing create_dataset function, adding FeatureStore to the feature_store init.py re-exports, and ensuring the migration guide references match actual code.
Related Issue
Related issue: 5496
Changes Made
sagemaker-mlops/src/sagemaker/mlops/__init__.pysagemaker-mlops/src/sagemaker/mlops/feature_store/__init__.pysagemaker-mlops/src/sagemaker/mlops/feature_store/feature_utils.pysagemaker-mlops/src/sagemaker/mlops/feature_store/MIGRATION_GUIDE.mdsagemaker-mlops/tests/unit/sagemaker/mlops/feature_store/test_feature_store_init.pyAI-Generated PR
This PR was automatically generated by the PySDK Issue Agent.
Merge Checklist
prefix: descriptionformat