feature: PartnerAppAuthProvider class support missing in 3.x (similar to 2.x) (5475)#5718
Draft
aviruthen wants to merge 1 commit intoaws:masterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PartnerAppAuthProvider feature already exists in the V3 sagemaker-core package at
sagemaker-core/src/sagemaker/core/partner_app/, with bothauth_provider.pyandauth_utils.pyand corresponding tests. However, there are several V3 convention violations and discoverability issues that need to be addressed: (1)RequestsAuthis not re-exported from__init__.pyfiles, so it lacks discoverability; (2) Theauth_provider.pyimportsboto3directly, which violates V3 conventions (V3 should use sagemaker-core session/credentials management, not raw boto3); (3) The classes don't follow V3 pydantic patterns for configuration. The primary fix involves ensuring proper re-exports, improving V3 convention compliance (replacing raw boto3 usage with sagemaker-core session management), and addingRequestsAuthto the public API exports.Related Issue
Related issue: 5475
Changes Made
sagemaker-core/src/sagemaker/core/partner_app/auth_provider.pysagemaker-core/src/sagemaker/core/partner_app/auth_utils.pysagemaker-core/src/sagemaker/core/partner_app/__init__.pysagemaker-core/src/sagemaker/core/__init__.pyAI-Generated PR
This PR was automatically generated by the PySDK Issue Agent.
Merge Checklist
prefix: descriptionformat