fix: MLFlow E2E Example Notebook (5513)#5727
Open
aviruthen wants to merge 1 commit intoaws:masterfrom
Open
Conversation
Collaborator
sagemaker-bot
left a comment
There was a problem hiding this comment.
🤖 AI Code Review
This PR fixes several real bugs in the MLflow E2E example notebook: replacing deprecated MLflow 3.x APIs (latest_versions, get_model_version_download_uri) and switching from raw boto3 endpoint invocation to the V3 SDK's core_endpoint.invoke() pattern. The changes are correct and align with V3 SDK conventions. A minor concern about the MLflow search API parameter name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The notebook at v3-examples/ml-ops-examples/v3-mlflow-train-inference-e2e-example.ipynb already exists but has several bugs related to MLflow 3.x API compatibility, incorrect V3 SDK Session usage, and inconsistency with existing V3 notebook patterns. Key issues: (1) Session.boto_region_name used as class attribute instead of instance attribute, (2) MLflow 3.x removed RegisteredModel.latest_versions — must use client.search_model_versions() instead, (3) client.get_model_version_download_uri() doesn't exist in MLflow 3.x — use model version's source attribute, (4) Endpoint invocation uses raw boto3 instead of core_endpoint.invoke() pattern from other V3 example notebooks, (5) The notebook should follow consistent patterns with the existing train-inference-e2e-example.ipynb.
Related Issue
Related issue: 5513
Changes Made
v3-examples/ml-ops-examples/v3-mlflow-train-inference-e2e-example.ipynbAI-Generated PR
This PR was automatically generated by the PySDK Issue Agent.
Merge Checklist
prefix: descriptionformat