Merged
Conversation
…call, move those to InitialReply
lucix-aws
reviewed
Feb 11, 2026
| @@ -0,0 +1,198 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
jfyi i deleted the thing that checks for this a while ago since it's not strictly required
lucix-aws
approved these changes
Feb 11, 2026
lucix-aws
reviewed
Feb 11, 2026
| Symbol structOutputSymbol; | ||
|
|
||
| if (EventStreamGenerator.isV2EventStream(model, operation)) { | ||
| List<MemberShape> onlyEventStreamMembers = outputShape.members().stream().filter(member -> StreamingTrait.isEventStream(model, member)).toList(); |
Contributor
There was a problem hiding this comment.
This is an excellent way to solve this, and one I hadn't considered.
…of invokeOperation
…te to InitialReply
…messes with some types that need to be ReadCloser
lucix-aws
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Add a new event stream generator to support
bedrockruntime#InvokeModelWithBidirectionalStream.This works in tandem with pull request xx in the SDK, where most of the description will happen
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.