fix: remove redundant hardcoded stack names in model_deploy seed code - #421
Merged
Conversation
Consolidate DevStage, PreProdStage, ProdStage into a single DeployStage class and add an explicit stage_name parameter to DeployEndpointStack for SageMaker resource naming. This avoids redundant CF stack names like "dev-dev-endpoint", adds project uniqueness to prevent cross-project collisions, and shortens SageMaker resource names.
newman911
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DevStage/PreProdStage/ProdStageclasses into a singleDeployStagein the model deploy seed codestage_nameparameter toDeployEndpointStackfor SageMaker resource naming, decoupling it from the CDK construct IDdev-dev-endpoint→dev-{project}-endpoint) and adds project uniqueness to prevent cross-project collisions in the same account…-dev-endpoint-endpoint→…-dev-ep)This only affects seed code copied to CodeCommit for new SageMaker projects. Existing projects are unaffected.
Test plan
stage_namevalues produce different SageMaker endpoint names