Fix model deploy pr - #428
Merged
Merged
Conversation
The model deployment template creates multiple CDK stacks (pipeline + cross-region + endpoint stacks per environment). Without --all flag, cdk deploy fails when multiple stacks exist. This fix ensures the CodeBuild project can deploy all stacks in cross-account/cross-region configurations.
newman911
force-pushed
the
fix-model-deploy-pr
branch
from
March 6, 2026 22:13
851431e to
1b034ea
Compare
kwangaws
approved these changes
Mar 9, 2026
|
|
||
| app = cdk.App() | ||
|
|
||
| # All deployment regions must match - cross-region endpoint deployment is not supported |
Contributor
There was a problem hiding this comment.
do we have any technical blocker regarding "cross-region endpoint deployment is not supported"?
Contributor
Author
There was a problem hiding this comment.
yes
All deployment regions must match - cross-region endpoint deployment is not supported
because model packages contain region-specific container image URIs
Contributor
There was a problem hiding this comment.
ah, my question was not clear. I meant to check why "model packages has to contain region specific container image URI" or " will cross region image pull be enough to address the above limitation. Maybe the actual question should be what needs to be done to support cross-region endpoint deployment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review
CHANGELOG.MDwith a description of my changesscripts/validate.sh)seedfarmer applyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.