Change usrsctp initialization function to not open raw sockets#1805
Closed
Change usrsctp initialization function to not open raw sockets#1805
Conversation
disa6302
approved these changes
Sep 13, 2023
Contributor
Author
|
Closing this as the original PR has been merged: #1796 |
sirknightj
added
the
test-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Issue: #1782
PR: #1796
What was changed?
Change usrsctp initialization function to not open raw sockets
Why was it changed?
Port 132 is opened by the usrsctp library. However, this port is not used by WebRTC and should not be open
How was it changed?
Using
usrsctp_init_nothreadsinstead ofusrsctp_initto prevent those unused sockets from being created (Ref: sctplab/usrsctp#532)What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.