Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@

import org.springframework.lang.Nullable;
import software.amazon.awssdk.enhanced.dynamodb.Key;
import software.amazon.awssdk.enhanced.dynamodb.model.DeleteItemEnhancedRequest;
import software.amazon.awssdk.enhanced.dynamodb.model.PageIterable;
import software.amazon.awssdk.enhanced.dynamodb.model.PutItemEnhancedRequest;
import software.amazon.awssdk.enhanced.dynamodb.model.QueryEnhancedRequest;
import software.amazon.awssdk.enhanced.dynamodb.model.ScanEnhancedRequest;
import software.amazon.awssdk.enhanced.dynamodb.model.UpdateItemEnhancedRequest;
Expand All @@ -39,6 +41,15 @@ public interface DynamoDbOperations {
*/
<T> T save(T entity);

/**
* Saves an item in DynamoDB using the provided PutItemEnhancedRequest.
*
* @param request the request object containing the item to be saved
*
* @see PutItemEnhancedRequest
*/
<T> void save(PutItemEnhancedRequest<T> request);

/**
* Updates Entity to DynamoDB table.
*
Expand Down Expand Up @@ -71,6 +82,17 @@ public interface DynamoDbOperations {
*/
<T> T delete(T entity);

/**
* Deletes a record for a given DeleteItemEnhancedRequest.
*
* @param request the request object containing the item to be deleted
* @param clazz the class type of the item to be deleted so
* {@link software.amazon.awssdk.enhanced.dynamodb.TableSchema} can be generated.
*
* @see DeleteItemEnhancedRequest
*/
<T> T delete(DeleteItemEnhancedRequest request, Class<T> clazz);

/**
* Loads entity for a given Key.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
import software.amazon.awssdk.enhanced.dynamodb.DynamoDbEnhancedClient;
import software.amazon.awssdk.enhanced.dynamodb.DynamoDbTable;
import software.amazon.awssdk.enhanced.dynamodb.Key;
import software.amazon.awssdk.enhanced.dynamodb.model.DeleteItemEnhancedRequest;
import software.amazon.awssdk.enhanced.dynamodb.model.PageIterable;
import software.amazon.awssdk.enhanced.dynamodb.model.PutItemEnhancedRequest;
import software.amazon.awssdk.enhanced.dynamodb.model.QueryEnhancedRequest;
import software.amazon.awssdk.enhanced.dynamodb.model.ScanEnhancedRequest;
import software.amazon.awssdk.enhanced.dynamodb.model.UpdateItemEnhancedRequest;
Expand Down Expand Up @@ -64,6 +66,12 @@ public <T> T save(T entity) {
return entity;
}

public <T> void save(PutItemEnhancedRequest<T> request) {
Assert.notNull(request, "putItemEnhancedRequest is required");
Assert.notNull(request.item(), "request item is required");
prepareTable(request.item()).putItem(request);
}

public <T> T update(T entity) {
Assert.notNull(entity, "entity is required");
return prepareTable(entity).updateItem(entity);
Expand All @@ -72,6 +80,7 @@ public <T> T update(T entity) {
@Override
public <T> T update(UpdateItemEnhancedRequest<T> request) {
Assert.notNull(request, "updateItemEnhancedRequest is required");
Assert.notNull(request.item(), "request item is required");
return prepareTable(request.item()).updateItem(request);
}

Expand All @@ -86,6 +95,12 @@ public <T> T delete(T entity) {
return prepareTable(entity).deleteItem(entity);
}

public <T> T delete(DeleteItemEnhancedRequest request, Class<T> clazz) {
Assert.notNull(request, "deleteItemEnhancedRequest is required");
Assert.notNull(clazz, "clazz is required");
return prepareTable(clazz).deleteItem(request);
}

@Nullable
public <T> T load(Key key, Class<T> clazz) {
Assert.notNull(key, "key is required");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
package io.awspring.cloud.dynamodb;

import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.Assert.assertThrows;

import java.util.ArrayList;
import java.util.List;
Expand All @@ -29,10 +30,13 @@
import org.springframework.util.StringUtils;
import software.amazon.awssdk.enhanced.dynamodb.*;
import software.amazon.awssdk.enhanced.dynamodb.model.*;
import software.amazon.awssdk.enhanced.dynamodb.model.DeleteItemEnhancedRequest;
import software.amazon.awssdk.enhanced.dynamodb.model.PageIterable;
import software.amazon.awssdk.enhanced.dynamodb.model.PutItemEnhancedRequest;
import software.amazon.awssdk.enhanced.dynamodb.model.QueryConditional;
import software.amazon.awssdk.enhanced.dynamodb.model.QueryEnhancedRequest;
import software.amazon.awssdk.enhanced.dynamodb.model.ScanEnhancedRequest;
import software.amazon.awssdk.enhanced.dynamodb.model.UpdateItemEnhancedRequest;
import software.amazon.awssdk.services.dynamodb.DynamoDbClient;
import software.amazon.awssdk.services.dynamodb.model.*;

Expand Down Expand Up @@ -322,6 +326,91 @@ void dynamoDbTemplate_saveAndScanForParticularIndex_entitySuccessful(DynamoDbTab
cleanUp(dynamoDbTable, personEntity2.getUuid());
}

@ParameterizedTest
@MethodSource("argumentSource")
void dynamoDbTemplate_saveConditionallyAndRead_entitySuccessfully(DynamoDbTable<PersonEntity> dynamoDbTable,
DynamoDbTemplate dynamoDbTemplate) {
UUID uuid = UUID.randomUUID();
PersonEntity personEntity = new PersonEntity(uuid, "foo", null);
PersonEntity secondPersonEntity = new PersonEntity(uuid, "foo", "jar");
PutItemEnhancedRequest<PersonEntity> putItemEnhancedRequest = PutItemEnhancedRequest.builder(PersonEntity.class)
.conditionExpression(Expression.builder().expression("attribute_not_exists(lastName)").build())
.item(secondPersonEntity).build();
// save a person with lastName "bar"
dynamoDbTemplate.save(personEntity);
// attempt to replace person with lastName "jar"
dynamoDbTemplate.save(putItemEnhancedRequest);
PersonEntity savedPersonEntity = dynamoDbTemplate.load(
Key.builder().partitionValue(secondPersonEntity.getUuid().toString()).build(), PersonEntity.class);
assertThat(savedPersonEntity).isEqualTo(secondPersonEntity);

cleanUp(dynamoDbTable, personEntity.getUuid());
}

@ParameterizedTest
@MethodSource("argumentSource")
void dynamoDbTemplate_saveConditionally_entityFails(DynamoDbTable<PersonEntity> dynamoDbTable,
DynamoDbTemplate dynamoDbTemplate) {
UUID uuid = UUID.randomUUID();
PersonEntity personEntity = new PersonEntity(uuid, "foo", "bar");
PersonEntity secondPersonEntity = new PersonEntity(uuid, "foo", "jar");
PutItemEnhancedRequest<PersonEntity> putItemEnhancedRequest = PutItemEnhancedRequest.builder(PersonEntity.class)
.conditionExpression(Expression.builder().expression("attribute_not_exists(lastName)").build())
.item(secondPersonEntity).build();
// save person with lastName "bar"
dynamoDbTemplate.save(personEntity);
// try to save new lastName "jar" for the same person
assertThrows(DynamoDbException.class, () -> {
dynamoDbTemplate.save(putItemEnhancedRequest);
});

cleanUp(dynamoDbTable, personEntity.getUuid());

}

@ParameterizedTest
@MethodSource("argumentSource")
void dynamoDbTemplate_deleteConditionally_entitySuccessfully(DynamoDbTable<PersonEntity> dynamoDbTable,
DynamoDbTemplate dynamoDbTemplate) {
UUID uuid = UUID.randomUUID();
PersonEntity personEntity = new PersonEntity(uuid, "notfoo", "bar");
DeleteItemEnhancedRequest deleteItemEnhancedRequest = DeleteItemEnhancedRequest.builder()
.conditionExpression(Expression.builder().expression("#nameNotBeDeleted <> :value")
.putExpressionName("#nameNotBeDeleted", "name")
.putExpressionValue(":value", AttributeValue.builder().s("foo").build()).build())
.key(Key.builder().partitionValue(personEntity.getUuid().toString()).build()).build();
dynamoDbTemplate.save(personEntity);
dynamoDbTemplate.delete(deleteItemEnhancedRequest, PersonEntity.class);

PersonEntity deletedEntity = dynamoDbTemplate
.load(Key.builder().partitionValue(personEntity.getUuid().toString()).build(), PersonEntity.class);

assertThat(deletedEntity).isNull();
}

@ParameterizedTest
@MethodSource("argumentSource")
void dynamoDbTemplate_deleteConditionally_entityFails(DynamoDbTable<PersonEntity> dynamoDbTable,
DynamoDbTemplate dynamoDbTemplate) {
UUID uuid = UUID.randomUUID();
PersonEntity personEntity = new PersonEntity(uuid, "foo", "bar");
DeleteItemEnhancedRequest deleteItemEnhancedRequest = DeleteItemEnhancedRequest.builder()
.conditionExpression(Expression.builder().expression("#nameNotBeDeleted <> :value")
.putExpressionName("#nameNotBeDeleted", "name")
.putExpressionValue(":value", AttributeValue.builder().s("foo").build()).build())
.key(Key.builder().partitionValue(personEntity.getUuid().toString()).build()).build();
dynamoDbTemplate.save(personEntity);
assertThrows(DynamoDbException.class, () -> {
dynamoDbTemplate.delete(deleteItemEnhancedRequest, PersonEntity.class);
});

PersonEntity deletedEntity = dynamoDbTemplate
.load(Key.builder().partitionValue(personEntity.getUuid().toString()).build(), PersonEntity.class);

assertThat(deletedEntity).isNotNull();
cleanUp(dynamoDbTable, personEntity.getUuid());
}

public static void cleanUp(DynamoDbTable<PersonEntity> dynamoDbTable, UUID uuid) {
dynamoDbTable.deleteItem(Key.builder().partitionValue(uuid.toString()).build());
}
Expand Down