Add Spring Integration channel adapters for SNS - #1473
Merged
maciejwalkowiak merged 2 commits intoSep 26, 2025
Conversation
artembilan
requested review from
MatejNedic,
maciejwalkowiak and
tomazfernandes
as code owners
September 17, 2025 16:57
github-actions
Bot
added
component: sns
MatejNedic
approved these changes
Sep 18, 2025
MatejNedic
left a comment
MatejNedic
left a comment
Member
There was a problem hiding this comment.
Looks good to me.
@maciejwalkowiak we should think of how to add SnsAsyncClient and other asyncClient to autoconfiguration
Contributor
Author
|
Hold on with the merge, please. |
* Add `spring-integration-http` as an optional dep into `spring-cloud-aws-sns`. * Add `SnsInboundChannelAdapter` to consume SNS notification over HTTP(S) * Add `SnsMessageHandler` to publish to an SNS topic. * The `SnsHeaderMapper` and `SnsBodyBuilder` are supporting classes for various SNS publish scenarios * The `SnsRequestFailureException` is a generic exception with a message a and request context to throw when publication fails * Add extra useful `SnsHeaders` constant for some Spring Integration message headers * Since `SnsMessageHandler` is based on the `SnsAsyncClient`, introduce an `SnsAsyncTopicArnResolver` for such an async use-case * Add `spring-cloud-aws-starter-integration-sns` * Document this new feature * Add missed `spring-cloud-aws-starter-integration-sqs` module int the root pom
* Simplify `try..catch` logic in the `SnsMessageHandler` and add missed `currentThread().interrupt()` * Add `.fifo` logic to the `SnsAsyncTopicArnResolver`
artembilan
force-pushed
the
spring-integration-sns
branch
from
September 18, 2025 17:09
108a133 to
383e5a9
Compare
MatejNedic
approved these changes
Sep 21, 2025
MatejNedic
left a comment
MatejNedic
left a comment
Member
There was a problem hiding this comment.
Thanks @artembilan !!! LGTM
maciejwalkowiak
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spring-integration-httpas an optional dep intospring-cloud-aws-sns.SnsInboundChannelAdapterto consume SNS notification over HTTP(S)SnsMessageHandlerto publish to an SNS topic.SnsHeaderMapperandSnsBodyBuilderare supporting classes for various SNS publish scenariosSnsRequestFailureExceptionis a generic exception with a message a and request context to throw when publication failsSnsHeadersconstant for some Spring Integration message headersSnsMessageHandleris based on theSnsAsyncClient, introduce anSnsAsyncTopicArnResolverfor such an async use-casespring-cloud-aws-starter-integration-snsspring-cloud-aws-starter-integration-sqsmodule int the root pom📢 Type of change
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps