Merged
Conversation
When think: true is passed to Ollama, thinking models (Qwen3 etc.) return thought content inline as <think>...</think> in the response body. This commit: - Adds chatRespProcessor / chatStreamRespProcessor callbacks to AxAIOpenAIBaseArgs so providers can post-process responses without subclassing AxAIOpenAIImpl - Implements extractThinkTags() for non-streaming responses - Implements processThinkStreamChunk() with stateful streaming support - Sets hasShowThoughts: true for Ollama - Adds tests for both tag extraction and the no-tag pass-through case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #495
Changes
New:
chatRespProcessor/chatStreamRespProcessorcallbacksAdded two optional callbacks to
AxAIOpenAIBaseArgs(following the existingchatReqUpdaterpattern), allowing providers to post-process responses without subclassingAxAIOpenAIImpl.Ollama think parameter support
thinkingTokenBudget: 'none'→ sendsthink: false(disables thinking, reduces latency)think: truehasThinkingBudgetandhasShowThoughtsboth set totrue<think>tag extractionWhen Ollama returns thinking content inline as
<think>...</think>, it is now extracted into thethoughtfield and removed fromcontent:processThinkStreamChunk()Testing
test:unit: 1854 passedtest:type-check: cleantest:lint: clean