Open
Conversation
Contributor
|
I think looks good, but we'll want to wait to merge this when synced with backend @luffykai |
Contributor
Author
|
I am going to update to 1.11.2 as they have high severity bugfix. CC @luffykai |
7f41df9 to
f7cb5e3
Compare
2c8874b to
f92bc7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this run was for 1.11.0, ideally shall be updated for 1.11.2 too
Note that newer rust compiler is likely faster.
Claude's benches Comparison
Document 1 = baseline (main branch), Document 2 = updated (reth-1.11.0 branch). Δ% = (updated - baseline) / baseline.
Summary
Main Cells Used
From 55,890,443 to 56,253,133 (+0.6%)
Key takeaways
Wins: internal.4 is dramatically faster (-35% wall time, -66% PCS opening), internal.3 is -24%, and internal.1 is -4%. Total sequential proof time is down ~15s (-0.8%). The
generate_perm_tracein reth.prove_stark dropped ~9%.Regressions: The parallel proof time increased by +7.6% (31.7s → 34.1s), driven primarily by leaf's parallel time jumping +27% (7.75s → 9.82s). internal.0's
pcs_opening_time_msavg is up +5.2% and max jumped from 989ms to 1,404ms. Theagg_keygenstark_prove time also crept up (+6.5%).The internal.4 improvement looks like the most significant structural change — same cell counts but radically less PCS work, suggesting a circuit or constraint change at the top aggregation level.